UndertaleModTool icon indicating copy to clipboard operation
UndertaleModTool copied to clipboard

Implement loading overhaul

Open Grossley opened this issue 3 years ago • 1 comments

Description

  1. Allow it to load partial data if it encounters an error while loading. This would normally result in the entire game being inaccessible. Saving is disabled in this mode, however everything else is available for read only access. This also allows data from the data file to be included in any issues made on GitHub.
  2. Record warnings and errors to a log in executable directory for user reference.
  3. ~~Allow streamlined creation of issue to GitHub if it fails to load the game properly, including log, game information, MD5, and steam page (if it exists).~~ This has been removed until safeguards are put in place to reduce adverse impact on the number of issues created. The removal of this feature has no other adverse impacts on the other features, and it is recommended to merge as is, so that this feature may be added with full functionality and safeguards in a future pull request.

Caveats

UndertaleModTool may possibly crash in an unexpected way due to partially loaded data. This may require more error handling in the new catch block in ReadUndertaleData or in other parts of the code. However, what else needs to be accounted for is unknown. No mechanism for clearing old logs has been implemented at this time in the tool itself. That will need to be done manually.

Notes

A fix has been implemented to prevent crashing of loading a room when no embedded texture pages exist. TODO: Investigate bytecode 15 games that use GMS2.

Grossley avatar Jul 02 '22 04:07 Grossley