galaxy-integration-humblebundle icon indicating copy to clipboard operation
galaxy-integration-humblebundle copied to clipboard

Official repo version behind / no PR for current version

Open grnassar opened this issue 3 years ago • 5 comments

Describe the bug In other community integrations, the "official" FriendsOfGalaxy repo seems to use a bot to identify when a PR is needed, and creates one when it sees the version has been updated. (See for example https://github.com/FriendsOfGalaxy/galaxy-integration-uplay/pulls and https://github.com/FriendsOfGalaxy/galaxy-integration-rockstar/pulls) Now, GOG doesn't necessarily seem to be actually processing those PRs since January, but for some reason the Humble plugin doesn't even have a PR in the queue for its updates. (https://github.com/FriendsOfGalaxy/galaxy-integration-humble/pulls) I am guessing the bot wasn't clever enough to realize 10 > 9 (aka string or digit compare vs numerical), but that's not your problem of course :) However, you could probably do the PR manually and then... well, it could sit there waiting like the other community integrations, I guess, but at least that's another step forward!

Expected behavior All handled downstream (don't we all wish!)

Plugin installed directly from Galaxy / manually from your repository releases

Provide logs n/a

grnassar avatar Apr 27 '22 22:04 grnassar

obviously not a bug, can't seem to unassign label -- apologies

grnassar avatar Apr 27 '22 22:04 grnassar

Just created an issue in the GOG API repo (closest thing I could see to where it would be applicable): https://github.com/gogcom/galaxy-integrations-python-api/issues/194 in case that helps.

grnassar avatar Apr 27 '22 22:04 grnassar

Hi, thanks for raising the problem.

I am guessing the bot wasn't clever enough to realize 10 > 9

I think the issue is caused by auto-disabling github actions after 60days of no activity: https://docs.github.com/en/actions/managing-workflow-runs/disabling-and-enabling-a-workflow so the other plugins will be affected in the future as well.

Issue on gog side is a good idea.

UncleGoogle avatar Apr 28 '22 10:04 UncleGoogle

That's a great point. I overlooked that possibility. Whatever the reason for the lack of PR, it may be a good idea (and certainly can't hurt, I'd think) to create a PR manually anyway, I think. Thank you for your time looking into this. I hope the issue on the gog side helps. It's not technically in the "right place," and they seem to not be very responsive to issues not being raised in the right place -- even in cases, like this one, where the "right place" doesn't actually exist anymore.

grnassar avatar Apr 28 '22 16:04 grnassar

For reference: https://github.com/FriendsOfGalaxy/galaxy-integration-humble/actions/workflows/sync.yml

UncleGoogle avatar Apr 29 '22 20:04 UncleGoogle