linkspector icon indicating copy to clipboard operation
linkspector copied to clipboard
verified publisher icon UmbrellaDocs

The project is lacking tests

Open marcindulak opened this issue 1 year ago • 3 comments

  1. ~~It may be an advantage to have some unit tests~~ Implemented in https://github.com/UmbrellaDocs/linkspector/commit/84dc8a3d218b4ed3d486c70098f208d569ff858f, more could be added.
  2. A larger advantage would be to preserve the functionality of the project by having a system for running regression tests against cases (md, asciidoc, etc) submitted by users

marcindulak avatar Feb 17 '24 10:02 marcindulak

Having tests could help to catch, or to verify cases like when issues are potentially closed without the feature being implemented in the expected way

https://github.com/UmbrellaDocs/linkspector/issues/25 https://github.com/UmbrellaDocs/linkspector/issues/26

marcindulak avatar May 05 '24 17:05 marcindulak

Thank you. Yup, I'm working on adding tests.

  • Added tests for image links and relative links

More to come.

gaurav-nelson avatar May 05 '24 23:05 gaurav-nelson

https://github.com/UmbrellaDocs/linkspector/issues/26 still seems not working for me as expected with https://github.com/UmbrellaDocs/linkspector/commit/9dc2d13c83a83394b97acc06c0c4edc7e0a59137

marcindulak avatar May 06 '24 21:05 marcindulak