Editor - Current note not highlighted

[DoubleDee73]

Please, do not create duplicate issues

Actual behaviour

While the text of the current note is highlighted in the editor, the actual note is not highlighted in red (anymore)

Expected behaviour

Currently selected note should be highlighted in text AND in the bar for the note

Steps to reproduce

1. Open any song in the editor
2. First note should be highlighted

Details

• USDX version: 2023.4
• Operating System + version: Windows 10 (21H2)

Example

the corresponding bar for "you" should be highlighted

This used to work. I deinstalled USDX 2023.4 and reinstalled 2023.3, and then I had this issue. I then deinstalled 2023.3 and installed 2020.4 and had this issue. Re-installing 2023.4 did not help either, and then I installed USDX on 2 other Windows computers where it is not highlighted either.

[barbeque-squared]

I think it's supposed to use P1 for the notes and P2 for the highlighted (but I'd have to check the code)? But either way, the weirdness doesn't end there.

On my setup, P1 = Yellow and P2 = Blue If I go into the Sing screen -> 1 Player -> Edit any song: In this case it's green, but I'm pretty sure what color it selects here isn't consistent at all. Probably changes per game-start.

If I go into the Sing screen -> 2 (or more) Player -> Edit any song:

@DoubleDee73

• I assume on your system(s) P1 = Blue and P2 = Red ?
• Can you verify my statement about it changing depending on if you have 1 or 2+ players selected? I never put any thought into it before (I just assumed it was something weird in my custom theme or many local modifications) but it's suspiciously consistent on my end now that you brought it to my attention.

[DoubleDee73]

@barbeque-squared Ahh. This clears things up.

My P1 is blue, and my P2 is red (probably as per default) When I select one player, which I had in this particular example, the active note is blue, while the other notes are also blue. If I change it to green, the active note remains blue, and the rest will turn green.

When I select two players (p1 = blue, p2 = red), the active note becomes red, and the remaining notes are blue. When I select two players (p1 = blue, p2 = green), the active note becomes green, the remaining notes are blue.

While I can live with that, I think, it'd be better, if at one point the active note became independent from the current color scheme of the configured players, or maybe use a totally different color. Or have a border around the active note...

[barbeque-squared]

Thanks for verifying that! I guess it likes to pick blue in your case.

I'm not sure whether there's ways into the editor without setting at least P1 (there is Options -> Editor but I have no idea how that's supposed to work) but the dependency on P2 needs to go, as I can definitely have a perfectly valid config file where only P1 has a color.

Luckily, I think the editor already has at least one color defined: the (by default) Red that highlights it in the lyric. There's probably always going to be an edge case somewhere, but I'm pretty sure that orange is a derivative from the Red somewhere. So that could already work.

I'll see what kind of colors are available, worst case it'd just be inactive -> P1, active -> the highlight color. Expect a PR somewhere this weekend.

[barbeque-squared]

Okay I retract that statement. I (still) have no idea where exactly it's getting the note colors from, but it's fairly irrelevant now that I discovered that the colors I was going to use (the in the default theme red+orange from the bar with the box thingies -- between the note grid and the lyrics) are actually hardcoded colors. I'd always assumed that the orange a mix between the highlight color for the lyrics and something else from the theme, but it's actually hardcoded.

As a workaround, I suggest to have at least 2 players active, or just set P1 to some different color.

[barbeque-squared]

Closing this as it's been fixed by #870 .

(in the future I might tinker around with 0 players -- to replace most of the jukebox functionality -- but in that case the editor should still be using P1 anyway, or else some hardcoded fallback color)