Allow both players to sing just p1 or p2 on Duets

[mjhalwa]

Please, do not create duplicate issues

Actual behaviour

On selection of a Duet song p1 and p2 are automatically assigned to 1st and 2nd mic without choice.

Expected behaviour

An intermediate screen allows both players to sing p1 or p2. This might also allow player 1 to sing p2 and vice versa.

Steps to reproduce

1. open usdx
2. Select "sing" (left-most button)
3. choose 2 players then enter song selection
4. choose a duet song
5. song starts an leaves players with automatic assignment of player 1 to p1 and player 2 to p2

Details

Some songs like "Circle of Life" have great differences between the parts of p1 and p2. In some songs one of them might be highly annoying to sing (e.g. only "lala"), in others one players sings less than the other. One might feel an unfair disadvantage from the very beginning of the song (eventhough total achievable points are the same). So I would like to be able to choose both players to sing either p1 or p2.

Bonus: Maybe (with some clever idea) allow both players to sing a mix of p1 and p2 for songs like "Hakuna Matata" where p1 and p2 alternate, but one would sing along the whole song if listening to it on the radio.

[barbeque-squared]

This was already on my list to eventually implement! Things like #627 make this easier, but I know it's still hardcoded in a lot of other places as well. Once most of these duplications/hardcodings are gone, this shouldn't actually be that hard to implement.

Another usecase for this is when P1 is more like a solo singer and P2 is the chorus. In a bigger group, you could set P1 to one or two players, while everyone else does the chorus.

I don't understand your Bonus idea though. Isn't that what non-Duet versions are for? Or do you mean that some players can sing P1, some others P2, and yet others some mixture? The latter would essentially require support for Trio (and then Quartet, Quintet, Sextet etc) which although not impossible on a technical level, I have no idea how this would be presented to the user on the sing screen.

[mjhalwa]

The idea behind Bonus is that sometimes duets (like "Hakuna Matata" frim Disney's Lion King) alternate in p1 and p2 parts that could be merged into a single Solo player. One could use the beat information to see if only p1 or p2 sings. Of course it is difficult for parts where p1 and p2 overlap - therefore Bonus :-) A fallback could be to use p1 on overlap.

[barbeque-squared]

Ah, I get it now. Yeah, the bonus is definitely not a priority then. Not because I disagree per se, but I don't think that kind of song manipulation is something that USDX should do -- especially not outside the built-in editor. Virtually all duets I have already had a separate solo .txt file.

But I can see the usefulness of this kind of "turn a duet into a solo" functionality elsewhere. I've been meaning to rewrite some of my personal USDX helper scripts as a webpage for some time now (basically you paste the txt, and then it can do stuff like split words, put linebreaks in better places) and unless there already exists a webpage where I can contribute to, this is also something I could add there.

(the USDX built-in editor can probably do some of the bonus functionality already somehow -- just don't ask me how -- but it's more geared towards song editing/creating anyway)

[mjhalwa]

I have another idea regarding the Bonus...

If USDX would allow to select which player sings which pX and allows multiple players to sing the same pX.

Then what about having the solo as an additional pX+1 in the txt file? Do you think, this would work? Then the Bonus is part of the txt generators work and can be selected by multiple players to sing it.

[EDIT] E.g. for "Hakuna Matata" this might look somehow like (hope you get the idea, not sure about the appropreate header format for usdx)

#P1=Timon
#P2=Pumba
#P3=Timon & Pumba
p1
...
p2
...
p3
...
E

[barbeque-squared]

Your example file is essentially just a Trio (= a Duet but with three things instead of two). Which USDX currently does not support, but if it did, yeah your example would work. But that's going to duplicate so much stuff between txt's, hm, perhaps there is some merit to auto-generate such a combined player...

But this is getting really off-topic. Can we keep this ticket to the original request (intermediate screen to select what P we're singing) ? If you really want to continue discussing the bonus feature, just make a separate ticket for that.

[mjhalwa]

Yes this is fine for me :-)

[basisbit]

Please avoiding syntactic changes in the txt file format which would break parsing in other applications or older usdx versions.

[mjhalwa]

I am sorry, this was not my purpose. I thought of using the already present syntax for P1 and P2, where I guessed PX might be possible as continuation of a counter. Anyways my basic Issue focuses on

• the "tracks" P1 and P2,
• USDX to allow players the selection of a prefered "track"
• multiple USDX players to select the same "track"
• a single player to select just 1 "track", leaving one of them unselected.