USDX
USDX copied to clipboard
UltraStar-Deluxe
Playing with more than 6 Players
Hello guys,
new version is supposed to support up to 12 singers I think.
But notes do not appear on screen and game crashed at end of the songs because it failed to load scores.
Are 8 and 12 players still under development or something is wrong with my config ?
thank you for your job!
I want to add to this:
On Linux, using the current version, if I select more than 6 players on the player screen, the game crashes with an EAccessViolation the moment I hit Enter (Continue). This is the only error output I get, there's nothing on the terminal nor in the logs.
I know that it has never rendered more than 6 players (at least on a single screen), but in the past I was at least able to get to the song selection screen.
EDIT: I'm not sure if this should be a separate issue or is related to this issue, let me know if I should create a separate one instead for my problem.
as far as I remember, playing with more than 6 players should be fully implemented in the code, but no one started to adjust the theme files for that. So it will try to get the positions for 8 or 12 player layout, which then causes a nullpointer exception because the theme does not contain these. It should be just opening the theme .ini files, a bit of reading to understand how the naming scheme works, and then add the (many!) lines for 12 player setup and manually calculating on which positions the graphics should show up on screen. Quite a tedious work, but the result would probably add 12-player-support to the game. Would be a nice pull-request.
Answering my own comment about the EAccessViolation: it's unrelated, see #630.
On topic: adding more players is (one of) the reasons I started PR's like #627. There will always be some unavoidable duplication for the various players-per-screen setups, but a good deal can also be avoided by just refactoring some stuff first. Suffice to say: that's not ever getting PR'd if even the simple stuff already takes this long.