CuraEngine
CuraEngine copied to clipboard
[CURA-9178] Port external Voronoi fixes
Workarounds and fixes for certain Arachne foibles. Mostly to do with crashes due to improper Voronoi generation by Boost (or pre-processing necessary for that).
See individual commit messages for greater explanation.
We received a mail from someone that pointed us to these extant fixes. Would be a shame if we didn't incorporate them ;-)
--> Currently in draft, as it only compiles, not tested yet at all!
--> Also there are some problems, see the discussion(s) below. My attempt(s) to fix these went beyond a port (but are simplified as well in way) and can be found in the CURA-9178_temp_sidebranch
.
Unit Test Results
25 tests ±0 25 :heavy_check_mark: ±0 13s :stopwatch: +5s 1 suites ±0 0 :zzz: ±0 1 files ±0 0 :x: ±0
Results for commit 42182a26. ± Comparison against base commit 36e778f9.
:recycle: This comment has been updated with latest results.
This looks very interesting as a solution for this long standing issue!
However I can't slice simple models with it. After Detected non-planar Voronoi diagram even after the rotation of input.
, it segfaults trying to access a point on an polygon that was destroyed.
This never worked properly for us, and we've got a completely different workaround by using the Wagyu library to fix our polygons instead. (See: #2030 )