CuraEngine icon indicating copy to clipboard operation
CuraEngine copied to clipboard

Don't remove surface mode both cutting mesh areas.

Open BagelOrb opened this issue 2 years ago • 4 comments

The polylines are recomputed by the stitching, so they should be cleared. However, the polygons should not be cleared for surface mode BOTH. They are already cleared for surface mode SURFACE, 35 lines above at line 150.

BagelOrb avatar Mar 15 '22 13:03 BagelOrb

I don't remember which bug this solves exactly, but judging from the code it should solve a bug where surface mode both would not generate any surface geometry in case of cutting meshes.

However, I'm not able to reproduce the bug in 5.1.0 image pyramid_mesh_surface_mode_cutting_mesh.zip

BagelOrb avatar Aug 08 '22 17:08 BagelOrb

Unit Test Results

25 tests  ±0   25 :heavy_check_mark: ±0   7s :stopwatch: -1s   1 suites ±0     0 :zzz: ±0    1 files   ±0     0 :x: ±0 

Results for commit 4a389e9d. ± Comparison against base commit 06364d5e.

github-actions[bot] avatar Aug 11 '22 17:08 github-actions[bot]

Reproduced bug in main: image

With the fix: image

cutting_surface_mode_both_bug.zip

BagelOrb avatar Aug 11 '22 17:08 BagelOrb

@devs see CURA-9534

BagelOrb avatar Aug 11 '22 17:08 BagelOrb