UlrichB22

Results 131 comments of UlrichB22

> Not sure why `moinmoin powered` is rendered both as text and logo; maybe delete the text. Same for `python powered`. > I like this text because you can use...

I did some tests with a small device size. Sorry for using a German environment. - **Modernized theme** with old layout on the left and new layout on the right....

> But we could align it so it is on the same height as other elements: I agree, this would be the best for the header of the modernized theme....

I prefer the 4th image (the bottom of white-clouds.jpg), but both are fine. If your work is finished, may I ask you to create a new short PR with one...

IMO this is ready to merge. @RogerHaase do you agree?

Some tests are failing with whoosh-reloaded 2.7.5. Following command gives an error: `pytest -k test_index_update src/moin/storage/middleware/_tests/test_indexing.py` ``` ======================================================================================== ERRORS ========================================================================================= _____________________________________________________________ ERROR at teardown of TestIndexingMiddleware.test_index_update _____________________________________________________________ cfg = @pytest.fixture...

_Now struggling with index files left open by whoosh, but I have the failure reproducible on Linux now so hoping to have a clean test run soon_ ``` ERROR src/moin/_tests/test_user.py::TestUser::test_recovery_token...

I have found that removing gc.collect() in indexing.py fixes the issue. gc.collect() affects performance and IMO should not be used in every store_revision() call. I have moved it to conftest.py...

Thanks for testing. Can you do two more tests with `pytest src/moin/storage/middleware/_tests/test_indexing.py`? 1. with whoosh-reloaded and `storage/middleware/indexing.py` from master branch including gc.collect() 2. with whoosh 2.7.4 When it runs successful...

There has been no human activity in the whoosh-reloaded repo in the last 6 months. A pull request was automatically closed after 60 days of no activity. I've spent a...