qudi icon indicating copy to clipboard operation
qudi copied to clipboard

Published 20 hours ago • verified publisher icon Ulm-IQO

Minicircuit SPDT switch hardware

Open alrik-durand opened this issue 3 years ago • 3 comments

Description

I've added a hardware file to support minicircuit SPDT hardware via SwitchInterface

Motivation and Context

This hardware controls one or multiple switch via SMA cables. It can connect either port 1 or port 2 to a COM port. This type of hardware can automatize the change of cabling configuration for SMA, BNC, etc. cables. This PR adds compatibility to it via switch interface.

How Has This Been Tested?

This has been tested with a brand new RC-4SPDT-A26 on the local network and a windows 10 computer.

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • [x] My code follows the code style of this project.
  • [x] I have documented my changes in the changelog (documentation/changelog.md)
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have added/updated for the module the config example in the docstring of the class accordingly.
  • [x] I have checked that the change does not contain obvious errors (syntax, indentation, mutable default values).
  • [ ] I have tested my changes using 'Load all modules' on the default dummy configuration with my changes included.
  • [x] All changed Jupyter notebooks have been stripped of their output cells.

alrik-durand avatar Oct 09 '20 14:10 alrik-durand

@alrik-durand thanks for your contribution.

I'm currently reworking the switch interface because it is quite old and lacks some functionality (https://github.com/Ulm-IQO/qudi/tree/switch_interface_rework). Therefore it would be good to wait a bit with this PR and than implement it right away with the new interface.

What do you think?

kay-jahnke avatar Oct 15 '20 07:10 kay-jahnke

Hi, I would be happy with a brand new interface and I don't mind waiting a bit and even doing the changes on this hardware. This hardware in fact has a 'A' or 'B' state for each channel so the new features will useful !

alrik-durand avatar Oct 15 '20 08:10 alrik-durand

Is this PR ready for review after the changes introduced by merging PR #623?

Neverhorst avatar Jan 26 '21 17:01 Neverhorst