Ujjawal Modi
Ujjawal Modi
@timabbott I have done the changes as per your comments. Please have a look.
> It would be extremely helpful if you can explain how you resolved the feedback, e.g. in https://github.com/zulip/zulip/pull/24219/files#diff-49b33fc9770f16be249573ac69270f5541e25f2fc12af6487d071a9d80bc10b4 @timabbott I have explained how I resolved the feedback. Please have a...
@alya please review this PR.
> Merged, thanks @Ujjawal3! > > There's a parallel change we should make in the /#groups panel (in development -- it'll replace the existing "User groups" settings UI but is...
@alya please review this PR. I have resolved merge conflicts but don't know why still it has conflicts label.
> Nice! > > 1. Let's make the input field full-width to make it more pleasant to input multiple groups. > 2. Is it possible to make the typeahead appear...
> Were you able to figure out how to make the typeahead appear immediately? If not, maybe @N-Shar-ma can help. I tried but cannot get how to make typeahead appear...
@alya I have updated the PR now typeahead suggestions appear immediately. Please have a look.
> I can take a look once conflicts have been resolved. Thanks! I have resolved the conflicts. You can take a look now.
@alya I have updated the PR. Now input is disabled when user is not allowed to add users and also added screenshots of disabled field in PR description. Please have...