Ujjawal Modi

Results 77 comments of Ujjawal Modi

@alya I have added screenshots for each possible settings configuration. Please have a look. Thanks !

> Thanks! I think the banners should always go in either increasing or decreasing permissions order (e.g., "members, moderators, admins" or "admins, moderators, members", but never "members, admins, moderators"). >...

@alya I have updated the PR and screenshots. Please have a look.

> Thanks! The banners look fine, but they don't live-update if I change the permission settings. I think you must have tried changing permissions of user-groups because on changing permissions...

I have opened #24562 addressing the changes to be done in #24198. I have to open a new PR since I cannot do changes in existing PR.

As #24562 is merged now, I think we should mark it for integration review.

> I think would be better to have the changes for showing the banner to admins always in a separate commit from commit doing the rewording and modify the commit...

I have done the changes and updated the screenshots.

@alya I have added screenshots with tooltips. Please have a look.