Ujjawal Modi

Results 77 comments of Ujjawal Modi

> Posted one comment. There are still a couple of comments like - [#23943 (comment)](https://github.com/zulip/zulip/pull/23943#discussion_r1134220878), [#23943 (comment)](https://github.com/zulip/zulip/pull/23943#discussion_r1134114317) and [#23943 (comment)](https://github.com/zulip/zulip/pull/23943#discussion_r1122076292), where there is no change and no reply. Please carefully...

@alya please review this PR. I have added the screenshots and screen capture of the new behaviour.

> Thanks! It looks like this part of the issue has not been implemented: > > > Admins should always be able to edit custom profile fields, regardless of the...

@alya I have made some changes. I have tested it and admin is able to make changes even when it is non editable for user. (A confirmation message of saving...

> @Ujjawal3 Posted a couple of comments. > > Some important points - > > * Currently the inputs are disabled in UI even when the user has not set...

> @Ujjawal3 Posted a couple of comments. > > Some important points - > > * Currently the inputs are disabled in UI even when the user has not set...

@sahil839 I have updated the PR. Please review it.

> Posted some comments. You would also need to add backend tests for this in `zerver/tests/test_custom_profile_data.py`. You can refer to https://zulip.readthedocs.io/en/latest/testing/testing-with-django.html. @sahil839 for backend test verification I need a custom...

> Posted some comments. You would also need to add backend tests for this in `zerver/tests/test_custom_profile_data.py`. You can refer to https://zulip.readthedocs.io/en/latest/testing/testing-with-django.html. @sahil839 I have added test verification. Please review it....