uffizzi icon indicating copy to clipboard operation
uffizzi copied to clipboard

Improve message if uffizzi unable to log in to docker registry.

Open NealArw opened this issue 2 years ago • 5 comments

  1. Go into CLI
  2. Sign in
  3. Try to connect any docker-registry (ecr, acr, etc..) using invalid credentials (run: bundle exec uffizzi connect docker-hub)

Result: Message: We were unable to log you in to docker registry. Please verify that your username and password are correct.

Suggestion: Specify which docker registry we can't log in to. In GHA it is hard to understand, which connection was failed:

image

NealArw avatar Sep 15 '22 14:09 NealArw

Test result:

2022-09-27_18-32

JessikaCastellano avatar Sep 27 '22 22:09 JessikaCastellano

@JessikaCastellano Please test and attach screenshots of cases when a custom docker registry and other registries are used (Amazon, Azure, Google).

moklidia avatar Oct 03 '22 09:10 moklidia

Tests

DockerHub: 2022-10-03_07-50-docker-hub

Azure: 2022-10-03_09-04-azure

Amazon: 2022-10-03_09-06-amazon

Google: 2022-10-03_09-14-google

GitHub Container Registry 2022-10-03_09-19-github-container

JessikaCastellano avatar Oct 03 '22 14:10 JessikaCastellano

Docker Registry:

2022-10-03_13-52-docker-registry

JessikaCastellano avatar Oct 03 '22 21:10 JessikaCastellano

New PR #283 open

Tests:

DockerHub 2022-10-07_16-30-docker-hub

Azure 2022-10-07_16-50-azure

Amazon 2022-10-07_16-51-amazon

Google 2022-10-07_16-52-google

GitHub Container Registry 2022-10-07_16-53-ghcr

Docker Registry 2022-10-07_16-54-docker-registry

JessikaCastellano avatar Oct 07 '22 21:10 JessikaCastellano

TESTED on prod - OK

# uffizzi connect gcr google.json
We were unable to log you in to Google. Please verify that your username and password are correct.

# uffizzi connect docker-hub
Username: 12351
Password:
We were unable to log you in to DockerHub. Please verify that your username and password are correct.

# uffizzi connect ecr
Registry Domain: ***
Access key ID: c1234c
Secret access key:
We were unable to log you in to Amazon. Please verify that your username and password are correct.

# uffizzi connect ghcr
Github Username: NealArw
Access Token:
We were unable to log you in to Github Container Registry. Please verify that your username and password are correct.

For docker-registry issue created https://github.com/UffizziCloud/uffizzi/issues/295

NealArw avatar Oct 31 '22 13:10 NealArw