uffizzi icon indicating copy to clipboard operation
uffizzi copied to clipboard

improving backend code quality for updating deployment via cli

Open the38th opened this issue 2 years ago • 5 comments

the38th avatar Jul 19 '22 09:07 the38th

Please, update the task description.

NealArw avatar Jul 19 '22 12:07 NealArw

for QA this improvements provides no behaviour changes, so you need to check that cli command uffizzi preview update deployment-DEPLOYMENT_ID PATH_TO_COMPOSE_FILE works as it worked before

the38th avatar Jul 19 '22 13:07 the38th

:point_right: 1. Update does not work

  • Create preview by uffizzi preview create
  • Run uffizzi preview update

Result: error Not Found

bash-5.1# bundle exec uffizzi preview create -o=json test-compose/uffizzi-compose-webhook-docker.yml
[✔] Creating containers...
[✔] Deploying preview...
  [✔] webhooks-test-app
{"id":"deployment-2","url":"https://deployment-2-default.app.qa-gke.uffizzi.com"}
bash-5.1# bundle exec uffizzi connect ghcr
Github Username:  NealArw
Access Token:
Successfully connected to GHCR
bash-5.1# bundle exec uffizzi preview update -o=json deployment-2 test-compose/uffizzi-compose-webhook-ghcr.yml
Not Found
bash-5.1#

NealArw avatar Jul 20 '22 07:07 NealArw

TESTED - OK

bash-5.1# bundle exec uffizzi preview create -o=json test-compose/uffizzi-compose-volumes-docker.yml
[✔] Creating containers...
[✔] Deploying preview...
  [✔] uffizzi_test_rails_simple
{"id":"deployment-11","url":"https://deployment-11-default.app.qa-gke.uffizzi.com"}

bash-5.1# bundle exec uffizzi preview update -o=json deployment-11 test-compose/uffizzi-compose-webhook-docker.yml
[✔] Creating containers...
[✔] Deploying preview...
  [✔] webhooks-test-app
{"id":"deployment-11","url":"https://deployment-11-default.app.qa-gke.uffizzi.com"}

NealArw avatar Jul 21 '22 08:07 NealArw

TESTED on prod - OK

# uffizzi preview create -o=json c.yml
[✔] Creating containers...
[✔] Deploying preview...
  [✔] redis
  [✔] postgres
  [✔] nginx
  [✔] example-voting-app-worker
  [✔] example-voting-app-vote
  [✔] example-voting-app-result
{"id":"deployment-4537","url":"https://deployment-4537-zakary-tillman-1-1e4m0u.app.uffizzi.com"}

# uffizzi preview update -o=json deployment-4537 c.yml
[✔] Creating containers...
[✔] Deploying preview...
  [✔] redis
  [✔] postgres
  [✔] nginx
  [✔] example-voting-app-worker
  [✔] example-voting-app-result
  [✔] example-voting-app-vote
{"id":"deployment-4537","url":"https://deployment-4537-zakary-tillman-1-1e4m0u.app.uffizzi.com"}

# uffizzi preview update -o=json deployment-4537 compose.yml
[✔] Creating containers...
[✔] Deploying preview...
  [✔] test_env
{"id":"deployment-4537","url":"https://deployment-4537-zakary-tillman-1-1e4m0u.app.uffizzi.com"}

NealArw avatar Jul 28 '22 14:07 NealArw