Grial-UI-Kit-Support icon indicating copy to clipboard operation
Grial-UI-Kit-Support copied to clipboard

UXDivers.Effects | Grial 3.0.68-RC errors out against XF 4.7 when loading theme LTR and RTL

Open npagare opened this issue 4 years ago • 8 comments

Description

With XF version 4.7 pre4 and also in GA - 1> I get following runtime error on Android

  • System.InvalidOperationException: 'The BindableProperty "Width" is readonly.' 2> Application hangs on iOS 13.5

Steps to Reproduce

  1. Take the sample Grial app with RTL enabled
  2. Upgrade XF to version 4.7 pre4
  3. compile and run it against Android 10 64bit emulator

Expected Behavior

App should work smoothly

Actual Behavior

gets error - System.InvalidOperationException: 'The BindableProperty "Width" is readonly.'

Basic Information

  • Version with issue: Grial 3 - 3.0.68-RC
  • Last known good version:
  • IDE: VS 16.6.2
  • Platform Target Frameworks:
    • iOS:
    • Android:
  • Android Support Library Version:
  • Nuget Packages:
  • Affected Devices:

Screenshots

image

image

npagare avatar Jun 14 '20 17:06 npagare

Same error with XF 4.7 GA too.

`06-17 16:32:24.183 D/Mono (26332): Assembly Ref addref UXDivers.Effects[0xe3574da0] -> Xamarin.Forms.Core[0xd0816140]: 50 System.InvalidOperationException: 'The BindableProperty "Width" is readonly.'

[HotReload] (2020-06-17 16:34:04.7): ERROR: Caught exception in AgentStatusChangedHandler at 212: Xamarin.HotReload.DebuggerTimeoutException: Failed to Inject Assembly at Microsoft.VisualStudio.Telemetry.WindowsErrorReporting.WatsonReport.GetClrWatsonExceptionInfo(Exception exceptionObject) at Microsoft.VisualStudio.Telemetry.WindowsErrorReporting.WatsonReport.GetClrWatsonExceptionInfo(Exception exceptionObject)`

npagare avatar Jun 17 '20 23:06 npagare

I think the error is hitting the line below in the LTRTheme.xaml It seems like such error should will popup on other attached properties like Height too. Right now, it is throwing that error only on the first occurrence.

    <Rectangle x:Key="MainMenuItemTemplateNewBadgeLayoutBounds"
               Width="{x:Static AbsoluteLayout.AutoSize}"
               Height="22"
               X="1"
               Y="0.5" />

Could this be similar (not same) to #694 ?

npagare avatar Jun 18 '20 01:06 npagare

Hi @IoTFier That "rectangle code" is not in the original code of LTRTheme.xaml or RTLTheme.xaml I think it is not related to Grial

fcastro07 avatar Jun 18 '20 18:06 fcastro07

Hi @fcastro07 , please don't close issues until I get to respond to your question raised in the conversation. Even, I have no interest in keeping tickets open. But, logically you should allow me to close the ticket once the issue is addressed.

Please open this ticket as I can't reopen it being not a owner / contributor on this repo.

I would appreciate that courtesy.

Thank you, Nilesh

npagare avatar Jun 18 '20 22:06 npagare

Nilesh. Sorry for the inconvenience. Feel free to ask whatever you want.

fcastro07 avatar Jun 22 '20 14:06 fcastro07

Hi @fcastro07 , thank you for your consideration.

In the migration of my App from Grial 2 to Grial 3 (3.0.68-RC now), I migrated one of the AbsoluteLayout.LayoutBounds

<Setter Property="AbsoluteLayout.LayoutBounds" Value="1,0.5,AutoSize,22" /> to <Rectangle x:Key="TemplateLayoutBounds" HeightRequest="22" WidthRequest="{x:Static AbsoluteLayout.AutoSize}" X="1" Y="0.5" /> in LTRTheme.xaml and similary in RTLTheme.xaml

Apparently, this is breaking since XF 4.7 pre-4 and now in XF 4.7 GA as well.

Changing Height and Width to HeightRequest and WidthRequest resolved one problem, but X and Y - attached properties of ViewElement are made as readonly. So, now, I am facing error System.InvalidOperationException: 'The BindableProperty "X" is readonly.'

Any clue ?

Have you Grial 3.0.68-RC compiled against XF 4.7 ? I want to use Shapes API and new Grid API changes.

Your help will be appreciated.

Thank you

npagare avatar Jun 22 '20 20:06 npagare

Hi @dirivero , @fcastro07 ,

Will you please help me with my request above?

It is the UXDivers.Effects that's failing ...

06-23 12:59:53.211 D/Mono (22235): Assembly Ref addref UXDivers.Effects[0x7f0a17281280] -> Xamarin.Forms.Core[0x7f0a0e3a9300]: 49 **System.InvalidOperationException:** 'The BindableProperty "X" is readonly.'

Is there a new update with the Grial Sample app in conjunction with XF 4.7 ?

Thank you,

npagare avatar Jun 23 '20 17:06 npagare

Xamarin Forms team have opened a issue after I reported this problem - https://github.com/xamarin/Xamarin.Forms/pull/11187

npagare avatar Jun 24 '20 17:06 npagare