Gorilla-Player-Support icon indicating copy to clipboard operation
Gorilla-Player-Support copied to clipboard

Possibility to use a custom navigation page

Open ShiroYacha opened this issue 7 years ago • 6 comments

Hi,

I see that currently Gorilla only supports rendering of pages inside a navigation page configuring with the Gorilla.json file. I wonder if there could be support to register custom navigation pages (along with different renderers)?

Thanks

ShiroYacha avatar Aug 16 '17 11:08 ShiroYacha

@ShiroYacha can you describe a bit more what are your needs? What do you mean with "along with different renderers"?

LeoHere avatar Aug 16 '17 11:08 LeoHere

@LeoHere for instance, i'm using the iconize library https://github.com/jsmarcus/Iconize they have IconToolbarItem that use their font icon, but it only renders on IconNavigationPage. So with Gorilla, I can't really visualize the icons.

ShiroYacha avatar Aug 16 '17 20:08 ShiroYacha

@ShiroYacha right, got it. You can't right now. We will consider for future release.

LeoHere avatar Aug 17 '17 22:08 LeoHere

@ShiroYacha yesterday we released Gorilla 1.1.0.4. On of the features we included is what you requested here, is the ability to customize how the navigation page should be instantiated.

Essentially now the Config object have a property called CustomPageWrapper that if defined will be invoked to wrap those pages that needs to be displayed within a navigation page, for example:

var config = new Config(...);
config.CustomPageWrapper = (p) => new NavigationPage(p);

The code above defines the default behavior of Gorilla.

Hope it helps.

LeoHere avatar Oct 06 '17 10:10 LeoHere

Hi thanks for the info. I just downloaded the new version. I didn't know cuz when I use the Gorillay player menu "Check for update" it says that it is up-to-date. Can you confirm this?

ShiroYacha avatar Oct 06 '17 11:10 ShiroYacha

@ShiroYacha that is because we still didn't update the server to push the new version to all our users. Mainly because we are still working on the documentation for the localization feature. But you should be able to download it from the download page.

LeoHere avatar Oct 06 '17 11:10 LeoHere