uxarray icon indicating copy to clipboard operation
uxarray copied to clipboard

DRAFT: BallTree and KDTree performance comparison

Open aaronzedwick opened this issue 1 year ago • 4 comments

Closes #572

Overview

Compares BallTree and KDTree performance on construction and querying of nearest neighbors on a large 30km mesh.

PR Checklist

General

  • [x] An issue is linked created and linked
  • [x] Add appropriate labels
  • [x] Filled out Overview and Expected Usage (if applicable) sections

aaronzedwick avatar Nov 15 '23 01:11 aaronzedwick

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@paullric @philipc2 Here is a notebook with a comparison between the BallTree and KDTree. @philipc2 do you want me to turn this into an example notebook to have on the UXarray documentation? I am not sure where this should really find it's home so to speak, it doesn't seem like we need an example notebook for constructing these trees since it is pretty simple, but maybe we want one?

aaronzedwick avatar Nov 15 '23 01:11 aaronzedwick

@aaronzedwick good work with the PR. If possible please provide a link to the file used for this notebook.

rajeeja avatar Nov 15 '23 03:11 rajeeja

@paullric @philipc2 Here is a notebook with a comparison between the BallTree and KDTree. @philipc2 do you want me to turn this into an example notebook to have on the UXarray documentation? I am not sure where this should really find it's home so to speak, it doesn't seem like we need an example notebook for constructing these trees since it is pretty simple, but maybe we want one?

This is a fantastic comparison. Given the size of the dataset, I don't think this should be a usage example. How about we start up a discussion post with the content of this notebook, maybe upload it as a GIST once it's completed?

Also, we should consider making a general "how do I use the KDTRee" notebook once we get #564 finished

philipc2 avatar Nov 15 '23 04:11 philipc2

@aaronzedwick

Should we go ahead and close this PR with #572 being merged now?

philipc2 avatar Jul 31 '24 22:07 philipc2