VIC icon indicating copy to clipboard operation
VIC copied to clipboard

Relic variables? Snow melting energy in particular

Open homefc opened this issue 12 years ago • 6 comments

After examining the snow melt energy output I concluded that the output values for that variable are not snow melting energy since they are non-zero mostly during the summer when SWE is zero. I don't know what that variable is outputing but since it's not affecting the rest of the variables I'm looking into, I won't look into it to move forward with my work. But I want others to know. Among things to check in the development of the model we should look into what variables are being used and which ones are relics and are not working properly and need to be repaired or eliminated.

homefc avatar Sep 20 '13 19:09 homefc

Ted - can you check what that variables is supposed to be. Seems to me this is mostly a matter of documentation - presuming the variable is meaningful.

bartnijssen avatar Sep 20 '13 20:09 bartnijssen

Not today. I have a lot on my plate today. I can look into it next week. And by that, I mean I will check the immediate problem (what is going into the melt energy variable). The task of going through all variables and double-checking that they are what they are supposed to be will take much longer.

On Fri, Sep 20, 2013 at 1:48 PM, bartnijssen [email protected]:

Ted - can you check what that variables is supposed to be. Seems to me this is mostly a matter of documentation - presuming the variable is meaningful.

— Reply to this email directly or view it on GitHubhttps://github.com/UW-Hydro/VIC/issues/56#issuecomment-24840253 .

tbohn avatar Sep 20 '13 20:09 tbohn

I didn't mean that to sound as brusque as it did. I will look into this, but in stages, as I have time.

On Fri, Sep 20, 2013 at 1:50 PM, Ted Bohn [email protected] wrote:

Not today. I have a lot on my plate today. I can look into it next week. And by that, I mean I will check the immediate problem (what is going into the melt energy variable). The task of going through all variables and double-checking that they are what they are supposed to be will take much longer.

On Fri, Sep 20, 2013 at 1:48 PM, bartnijssen [email protected]:

Ted - can you check what that variables is supposed to be. Seems to me this is mostly a matter of documentation - presuming the variable is meaningful.

— Reply to this email directly or view it on GitHubhttps://github.com/UW-Hydro/VIC/issues/56#issuecomment-24840253 .

tbohn avatar Sep 20 '13 20:09 tbohn

Sure - no problem - that's why I did not link it to a milestone and why it got the label "documentation" and "question" rather than "bug" or "hotfix"

On Sep 20, 2013, at 1:54 PM, Ted Bohn [email protected] wrote:

I didn't mean that to sound as brusque as it did. I will look into this, but in stages, as I have time.

On Fri, Sep 20, 2013 at 1:50 PM, Ted Bohn [email protected] wrote:

Not today. I have a lot on my plate today. I can look into it next week. And by that, I mean I will check the immediate problem (what is going into the melt energy variable). The task of going through all variables and double-checking that they are what they are supposed to be will take much longer.

On Fri, Sep 20, 2013 at 1:48 PM, bartnijssen [email protected]:

Ted - can you check what that variables is supposed to be. Seems to me this is mostly a matter of documentation - presuming the variable is meaningful.

— Reply to this email directly or view it on GitHubhttps://github.com/UW-Hydro/VIC/issues/56#issuecomment-24840253 .

— Reply to this email directly or view it on GitHub.

bartnijssen avatar Sep 20 '13 20:09 bartnijssen

@tbohn : If you can provide a few words on what that variable is supposed to be that would be great. I don't want it to hold up release of version 5.0, so I am going to bump it down the road (but still would be nice to close it out).

bartnijssen avatar Aug 17 '16 21:08 bartnijssen

Why don't we link this to 5.1? I've been held up a bit here at ASU but I expect to resume development work on VIC (e.g., WRF Hydro driver, timeseries of LAI, a few other cleanup issues like removing redundant lake state variables, etc) starting in September.

tbohn avatar Aug 18 '16 00:08 tbohn