Time varying albedo

[jhamman]

The CESM and Image drivers both have a block of code in them that looks like this:

        for (v = 0; v < options.NVEGTYPES; v++) {
            vidx = veg_con_map[i].vidx[v];
            if (vidx != -1) {
                // not the correct way to calculate average albedo in general,
                // but leave for now (it's correct if albedo is constant over
                // the model step)
                veg_hist[i][vidx].albedo[NR] = average(veg_hist[i][vidx].albedo,
                                                       NF);
                veg_hist[i][vidx].LAI[NR] = average(veg_hist[i][vidx].LAI, NF);
                veg_hist[i][vidx].fcanopy[NR] = average(
                    veg_hist[i][vidx].fcanopy, NF);
            }
        }

This issue is meant to raise the issue stated in the comment regarding the correct way to average albedo.

[bartnijssen]

I guess it only matters once we actually have a time varying albedo. Until then it makes no actual difference, so I am going to mark it someday

[tbohn]

Didn't @dgergel 's PR's earlier this year regarding albedo averaging (July or August, I think? sorry, don't recall the PR and not finding it after a cursory check) address this issue?

[dgergel]

@tbohn that one didn't address this - because that PR was for gridcell-averaged albedo - so spatially rather than temporally averaged

[tbohn]

OK, sorry...