vpc no longer required? vpc as a s3 method?
Hi,
I was trying to see where the vpc package is used? Is it no longer used? If so, it can be dropped as a dependency.
Also, I was wondering if you wouldn't mind making the vpc a s3-compatible object. This way in nlmixr I can import your excellent package and then do a vpc simulation on a simple fit object without having to worry about the vpc conflict in etiher xpose or vpc packages
Hello Matt,
- The vpc package is used by the
vpc_data()function of xpose. - Moving xpose toward a full s3 approach is a top priority on my todo list. I am unhappy with the my current implementation and when time allows me I will work toward this to facilitate 3rd party integrations such as
nlmixr,monolixandphoenix nlme.
I could submit a pull request for the s3 method of vpc. It is simple enough. Ron already merged my pull request for a s3 vpc method so all 3 packages would be aligned.
That would be great. Thanks!
I will submit something once https://github.com/ronkeizer/vpc/issues/46 is resolved.
No worries, I will be afk next week anyway :-)