PyVerse icon indicating copy to clipboard operation
PyVerse copied to clipboard
Published 3 months ago • verified publisher icon UTSAVS26

dp-basic-series

Open NK-Works opened this issue 1 year ago • 1 comments

Pull Request for PyVerse 💡

Requesting to submit a pull request to the PyVerse repository.

Issue Title

Please enter the title of the issue related to your pull request.
Dynamic Programming Series (Dynamic Programming Basic Algos)

  • [x] I have provided the issue title.

Info about the Related Issue

What's the goal of the project?
A dynamic programming learning library

  • [x] I have described the aim of the project.

Name

Please mention your name.
Anneshu Nag

  • [x] I have provided my name.

GitHub ID

Please mention your GitHub ID.
NK-Works

  • [x] I have provided my GitHub ID.

Email ID

Please mention your email ID for further communication.
[email protected]

  • [x] I have provided my email ID.

Identify Yourself

Mention in which program you are contributing (e.g., WoB, GSSOC, SSOC, SWOC).
GSSOC, Hacktoberfest

  • [x] I have mentioned my participant role.

Closes

Enter the issue number that will be closed through this PR.
Closes: #538

  • [x] I have provided the issue number.

Describe the Add-ons or Changes You've Made

Give a clear description of what you have added or modified.
I have added the basic easy dp algos

  • [x] I have described my changes.

Type of Change

Select the type of change:

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [x] Code style update (formatting, local variables)
  • [x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [x] This change requires a documentation update

How Has This Been Tested?

I tested them by running them

  • [x] I have described my testing process.

Checklist

Please confirm the following:

  • [x] My code follows the guidelines of this project.
  • [x] I have performed a self-review of my own code.
  • [x] I have commented my code, particularly wherever it was hard to understand.
  • [x] I have made corresponding changes to the documentation.
  • [x] My changes generate no new warnings.
  • [x] I have added things that prove my fix is effective or that my feature works.
  • [x] Any dependent changes have been merged and published in downstream modules.

NK-Works avatar Oct 14 '24 05:10 NK-Works

👋 Thank you for opening this pull request! We're excited to review your contribution. Please give us a moment, and we'll get back to you shortly!

Feel free to join our community on Discord to discuss more!

github-actions[bot] avatar Oct 14 '24 05:10 github-actions[bot]

@UTSAVS26 how long does a review usually take... i mean i wanna open new issues for the follow ups but if this PR doesnt get merged then it wont be of any point

NK-Works avatar Oct 15 '24 18:10 NK-Works

@UTSAVS26 how long does a review usually take... i mean i wanna open new issues for the follow ups but if this PR doesnt get merged then it wont be of any point

Sorry for the delay but it usually takes time to be merged as you can also see there are many contributors who are contributing we need to check them personally if there project or the addon they do works properly or not and also is it along with repo idea.

I will merge it.

UTSAVS26 avatar Oct 16 '24 02:10 UTSAVS26