utrs icon indicating copy to clipboard operation
utrs copied to clipboard

Cleanup appeal sorting, improve appeal list styling

Open supertassu opened this issue 5 years ago • 6 comments

Reviewing with whitespace changes ignored is recommended. (Files changed -> click gear icon -> enable "Hide whitespace changes" -> apply)

  • Fix some appeals appearing twice (closes #232)
  • Cleanup code style in AppealController. I checked the raw SQL queries being executed weren't modified (except fixing #232)
  • Cleanup formatting and code style in appeal list. Notably changes dark background to light, uses table formatting instead of bg-* classes, adds reserving admin to list. See screenshots:
Current

image

New

image

supertassu avatar Jul 04 '20 10:07 supertassu

I'm concerned that the color changes are not assisting in our accessibility by not having a sufficient contrast ratio. The original colors were chosen for that reason. There is still an issue currently with blue and yellow rows having proper contrast ratio, but this new option now makes every URL pop up with an accessibility issue.

For people I know either directly or indirectly, the new colors pose more of a struggle to use, and it creates even more white-space (which we already have enough of).

This is why I initially rejected it in the last review.

dqwiki avatar Jul 04 '20 14:07 dqwiki

How about this:

Screenshot

image

It still keeps the link colors and dark background but makes the backgrounds less flashy.

supertassu avatar Jul 05 '20 17:07 supertassu

Everything but the yellow seems to stand out enough.

dqwiki avatar Nov 18 '20 15:11 dqwiki

New screenshot: Screenshot from 2021-09-11 22-51-44

supertassu avatar Sep 11 '21 19:09 supertassu

Uploading Screenshot_2024-12-01-00-57-21-78_22e4250240c136c826b8a3b1264b092d.jpg…

avit226 avatar Jan 16 '25 21:01 avit226