usrse.github.io icon indicating copy to clipboard operation
usrse.github.io copied to clipboard

[feature] Improve layout of redirected pages

Open exoticDFT opened this issue 4 years ago • 4 comments

The current way we are redirecting pages is done using the default page layout. Therefore the title and subtitle will still be displayed with a redirecting message.

It would be good to create a redirect layout to use for current and future pages that need to be redirected. We could do this either manually or with the jekyll-redirect-from plugin.

exoticDFT avatar Mar 19 '21 02:03 exoticDFT

The plug-in is probably not necessary because the code is pretty simple and we already have it for the most part (and it’s good to be conservative and limit external dependencies) but we easily could change the redirect layout or timing to be different!

vsoch avatar Mar 19 '21 02:03 vsoch

The plug-in is probably not necessary

Actually, the jekyll-redirect-form is already part of of github-pages gems.

$ cat Gemfile.lock | grep redirect
      jekyll-redirect-from (= 0.14.0)
    jekyll-redirect-from (0.14.0)

and it’s good to be conservative and limit external dependencies

And, not only that we are having all these plugins as well (thanks to github-pages gem we are using 😉 ):

    jekyll-avatar (0.6.0)
    jekyll-coffeescript (1.1.1)
    jekyll-commonmark (1.3.1)
    jekyll-commonmark-ghpages (0.1.5)
    jekyll-default-layout (0.1.4)
    jekyll-feed (0.11.0)
    jekyll-gist (1.5.0)
    jekyll-github-metadata (2.9.4)
    jekyll-mentions (1.4.1)
    jekyll-optional-front-matter (0.3.0)
    jekyll-paginate (1.1.0)
    jekyll-readme-index (0.2.0)
    jekyll-redirect-from (0.14.0)
    jekyll-relative-links (0.5.3)
    jekyll-remote-theme (0.3.1)
    jekyll-sass-converter (1.5.2)
    jekyll-seo-tag (2.5.0)
    jekyll-sitemap (1.2.0)
    jekyll-swiss (0.4.0)
    jekyll-theme-architect (0.1.1)
    jekyll-theme-cayman (0.1.1)
    jekyll-theme-dinky (0.1.1)
    jekyll-theme-hacker (0.1.1)
    jekyll-theme-leap-day (0.1.1)
    jekyll-theme-merlot (0.1.1)
    jekyll-theme-midnight (0.1.1)
    jekyll-theme-minimal (0.1.1)
    jekyll-theme-modernist (0.1.1)
    jekyll-theme-primer (0.5.3)
    jekyll-theme-slate (0.1.1)
    jekyll-theme-tactile (0.1.1)
    jekyll-theme-time-machine (0.1.1)
    jekyll-titles-from-headings (0.5.1)
    jekyll-watch (2.2.1)

See current list https://pages.github.com/versions/.

More painful for me to see is those jekyll-theme-* plugins which we are not even using 😞

brgnepal avatar Mar 19 '21 06:03 brgnepal

Yuck, I guess we are already in dependency hell! Whatever you decide to do, I’m ok with then, both options are just about the same.

vsoch avatar Mar 19 '21 07:03 vsoch

I am in favor of jekyll-redirect-form plugin as it is battle-tested. However, not sure about those dependent gems. My usual Gemfile has these much for any standard website I develop:

gem "jekyll", "~> 4.1.1"
gem 'html-proofer'

group :jekyll_plugins do
  gem "jekyll-seo-tag"
  gem "jekyll-paginate-v2"
  gem "jekyll-redirect-from"
end

brgnepal avatar Mar 19 '21 07:03 brgnepal

Is this issue still relevant? Seems like it was related to the old site? If I'm wrong, please feel free to reopen

kescobo avatar Jun 13 '23 02:06 kescobo