usrse.github.io
usrse.github.io copied to clipboard
USRSE
[feature] Automate notification of PR on slack
It would be great to automate the Slack channel of a PR, rather than being a manual part of our PR checklist.
Potential solutions:
- This can be done with GitHub Actions. Not sure the right choice for our current CI process.
- We could use this CircleCI integration. Related blog post about this.
Welcome to us-rse! We are excited that this is your first issue!
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Welcome @exoticDFT ! haha, I think you've been here a while, but it's still a celebratory moment for your first issue! :confetti_ball:
So the assumption is that most people don't get email notifications? And having all these added notifications in the website channel wouldn't be too much? Where I've seen integrations like this, there is a channel just for the notification. But then because of that, not many people look at it. Personally, I get emails so it would be a double notification for me.
So the assumption is that most people don't get email notifications? And having all these added notifications in the website channel wouldn't be too much? Where I've seen integrations like this, there is a channel just for the notification. But then because of that, not many people look at it. Personally, I get emails so it would be a double notification for me.
Double notifications could become an issue. So I'm definitely not suggesting making a ton of notifications on the Slack channel. Just ones we deem beneficial as a group. But we specifically have a checkbox in our PR form that says "I have posted the link for the PR in the usrse slack (#website) to ask for reviewers". Instead of making the requester do this manually, we could have one of the above options do it for us automatically.
We could kill two birds with one stone if we create a website notifications channel, then people can choose to be notified on slack or not, and people wouldn’t have to double copy paste.
I think this might be solving a problem that doesn't exist. We don't have tons of PRs, but if it gets to be more having them in the slack channel might obfuscate actual discussion. I'd be curious how many @USRSE/usrse-maintainers actually want the PRs posted in slack. If they do, I like @vsoch's suggestion of doing it in a different channel. If they don't, then let's remove it as a checkbox.
I like suggestion of having a dedicated channel on Slack which allows flexibility in notifications.
@exoticDFT are you still interested in doing this? I'll mark it post live if yes, if not please feel free to close.
Seems like the answer was "no" here? Can always reopen if it seems useful at another time
