Stormwater-Management-Model icon indicating copy to clipboard operation
Stormwater-Management-Model copied to clipboard

Published 20 hours ago • verified publisher icon USEPA

Where to Post Bug Fixes

Open LRossman opened this issue 5 years ago • 4 comments

I have updated the v5.1.013 source files to fix all of the bugs identified to date. They appear in the attached zip file along with a set of examples for each bug fix. It appears that this repo is strictly archival and doesn't allow branches cloned off of the master to be published. Is the OWA-SWMM repo the place to push these bug fixes? If so, will they find their way into an official EPA-SWMM release anytime soon? swmm5.1.013_Bug_Fixes.zip

LRossman avatar Jun 11 '19 16:06 LRossman

Thanks, @LRossman for all you do and have done for SWMM. I would suggest that the files not be called just bugs.inp. Maybe a JSON file for each file to describe them.

dickinsonre avatar Jun 11 '19 18:06 dickinsonre

@LRossman, I hope I'm not being presumptuous with this idea but it feels like there is an active development community around OWA-SWMM more than any other place. How do you and other community members feel about branching off master at OWA-SWMM and submitting the PR of bug fixes into that? Else, it is also reasonable to post them into EPA-SWMM's page, then I can merge/mesh them down into OWA-SWMM. I think this topic merits a larger discussion with the communit(y/ies). What are your thoughts?

bemcdonnell avatar Jun 11 '19 21:06 bemcdonnell

@bemcdonnell I just tried to publish a branch I created off of develop in the OWA-SWMM repo with the bug fixes in it but GitHub said I did not have permission to access the repo.

LRossman avatar Jun 13 '19 01:06 LRossman

@lrossman, let me fix that. I’ll update the permissions today!

bemcdonnell avatar Jun 13 '19 12:06 bemcdonnell