USEPA
Module 3 Task List
A list of more immediate task items related to the TADA analysis module to prioritize for now as we continue to brainstorm other considerations for this project.
- [x] Create a data dictionary excel tab in output of TADA mod 3 functions
- [x] Update the WQP Characteristic to ATTAINS Parameter Name alias table
- [x] Discuss crosswalk between ATTAINS Water Type to WQP MonitoringLocationTypeName
- [ ] Discuss Salt and Fresh Water Identifier - should this be a manual process?
- [x] Come up with a better method for 'auto_assign' of Use Names to new ATTAINS Parameter Name in TADA_CreateUseParamRef - depending on Shiny workflow considerations, can we leverage the output from TADA_CreateUseAURef? We can reduce the Use and Param Ref output by only pulling in a Use for a Parameter if the Parameter falls under a Water Type specified in the output of TADA_CreateUseAURef, if a user has ran it.
- [ ] Renaming of Mod 3 functions for better clarity of its use case. Consider relocating certain module 3 functions to a different .R file as we think through the workflow more (ex. should some of these functions be relocated to the geospatial .R file or elsewhere)?
- [x] Create a function to handle a user supplied list of Existing AUs (AUs that have already been submitted to ATTAINS) to ML and allow the ability to compare and review their crosswalk with the output from TADA_GetATTAINS with a flagging column.
- [x] MVP CriteriaSummary Output for just magnitude values and individual excursion summary. Have some draft code of summary output to share before July 28th meeting to allow TT R8 to leverage TADA function.
I would be interested in helping with this:
"Create a function to handle a user supplied list of Existing AUs (AUs that have already been submitted to ATTAINS) to ML and allow the ability to compare and review their crosswalk with the output from TADA_GetATTAINS with a flagging column."
I already created a function TADA_GetATTAINSAUSiteCrosswalk which pulls any existing ML/AUID combos from ATTAINS, so could build off that to help with the new function.
I created a separate issue for "Discuss crosswalk between ATTAINS Water Type to WQP MonitoringLocationTypeName" because that could be included in the future as part of the Module 2 site/AU crosswalk process: https://github.com/USEPA/EPATADA/issues/641
For the task of a "salt and freshwater indicator" for ATTAINS.WaterType and WQX.MonitoringLocationType, do you recommend a manual labelling be done internally by our TADA team? Or would this need to be specified by the user? Is the WQX.MontioringLocationType not always accurately labeled?
Name change suggestions:
- TADA_CreateParamRef to TADA_ParametersForAnalysis
- TADA_CreateUseParamRef to TADA_UsesForAnalysis
- TADA_CreateMLSummaryRef to TADA_SiteSpecificSummary
- Any suggestions for TADA_DefineCriteriaMethodology name change? Or do you like it the way it is.
Name change suggestions:
- TADA_CreateParamRef to TADA_ParametersForAnalysis
- TADA_CreateUseParamRef to TADA_UsesForAnalysis
- TADA_CreateMLSummaryRef to TADA_MLSummary
- Keep TADA_DefineCriteriaMethodology