cereal icon indicating copy to clipboard operation
cereal copied to clipboard

CVE-2020-11105 fix vs. boost::intrusive_ptr

Open jamesjer opened this issue 3 years ago • 3 comments

The fix for CVE-2020-11105 in version 1.3.1 requires that std::shared_ptr be used, but at least one cereal consumer, e-antic, uses boost::intrusive_ptr instead. It might be possible to subclass OutputArchive to deal with this, but the relevant member variables are all private, not protected. As a result, the e-antic package has been left in an unbuildable state in Fedora ever since we upgraded to cereal 1.3.1. Would you consider making itsSharedPointerMap protected so that consumers can deal with this situation? Or explicitly add support for boost::intrusive_ptr?

jamesjer avatar Jan 23 '22 22:01 jamesjer

Going to protected wouldn't be a big deal - can you provide a link to how e-antic is using boost::intrusitve_ptr in relation to cereal?

AzothAmmo avatar Jan 30 '22 02:01 AzothAmmo

We managed to produce a workaround, so I think this can be closed: https://github.com/flatsurf/e-antic/pull/242/files#diff-ec3c5ba2da803488d40687a86e9398c02b99cdf46d000d8a2eb7218182fcb1ddR32

saraedum avatar Sep 14 '22 18:09 saraedum

您的邮件我已收到,谢谢合作!

redchairman avatar Sep 14 '22 18:09 redchairman