square-core icon indicating copy to clipboard operation
square-core copied to clipboard

Make the local-minimal version runnable again

Open kwang2049 opened this issue 2 years ago • 2 comments

What does this PR do?

It seems that some new lines have been added and the current local minimal version cannot run successfully. This PR fixes the issue.

Changes:

  • Traefik port 8080->8081: 8080 is very likely to be in use already;
  • Commented out BERT-ONNX-worker: Some file is missing. One can add it back when the file is provided;
  • Corrected comment format in the yaml file: # -> #!;
  • Generate .env file for model manager.

Before submitting / marking as 'ready to review'

  • [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • [ ] Did you make sure to update the documentation with your changes?
  • [ ] Did you write any new necessary tests?

Who can review?

Feel free to tag members/contributors who may be interested in your PR.

kwang2049 avatar Feb 13 '23 12:02 kwang2049

@Rachneet a file is missing: https://github.com/UKP-SQuARE/square-core/blob/49ef708a2193b9057a9b61a12a6b65b63ebe3935/docker-compose.ytt.min.yaml#L218

kwang2049 avatar Feb 13 '23 12:02 kwang2049

Does anybody know how to add CI tests for this minimal version? @timbmg @Rachneet We can then make it easier for maintaining

kwang2049 avatar Feb 13 '23 12:02 kwang2049