CyberKit
CyberKit copied to clipboard
New to iOS 14 color space conditionals do not actually exist in iOS 14.0.x
In CyberKit, we currently have the following in PlatformHave.h:
https://github.com/UInt2048/CyberKit/blob/cd93bb79b22d4ee0fc4481e041a6eacf33623792/Source/WTF/wtf/PlatformHave.h#L980-L990
Unfortunately, when checking the SDK for 14.0, these things aren't actually there. A crash report from a real device has confirmed this is not an issue with the SDK.
The immediate fix would be to set the conditional to iOS 14.1+ but due to the practice of building CyberKit for major releases, would have the effect of disabling this support until iOS 15, which is not ideal.
Ideally then, in the iOS 14 build, we should surround these usages in functions, especially in ColorSpaceCG.cpp, with runtime checks to confirm iOS 14.1+, so that CyberKit doesn't crash on 14.0, but 14.1+ still gets to use these.
Should be fixed in 5fc73ce55375455933f8322bc4a3d14781ee6b36. I'll close when there's a nightly to test this.