UI icon indicating copy to clipboard operation
UI copied to clipboard

Weather Popup doesn't work on Weather Card

Open tropics1999 opened this issue 2 years ago • 6 comments

Describe the bug When adding the weather popup via ulm_custom_popup to the weather card behaviour is not changed - ie the card will still show the weather entity details instead of the popup when clicked.

To Reproduce Added the below to my yaml file, the card displays and works correctly except for the popup.

- type: "custom:button-card"
   template: card_weather
     entity: weather.hackham
     variables:
       ulm_card_weather_name: " "
       ulm_card_weather_enable_popup: true
       ulm_card_tap_action: "popup"  
       ulm_custom_popup:
         template: "popup_weather_forecast"
         popup_variables:
           ulm_popup_weather_entity: weather.hackham

Additional context I successfully added the popup to the Temperature Chip (chip_temperature template), and it worked as expected - so the issue appears isolated to the weather card. I also tried overriding every action using the ulm_xxx_xxx_action variables I found on this page of the wiki to "popup".

Thanks in advance for your help and sorry if I am doing something wrong or missed a part of the documentation.

tropics1999 avatar Aug 10 '22 12:08 tropics1999

I have also tried to add it to Custom Card "Welcome Navigation" and got the same issue.

Nicxe avatar Aug 10 '22 13:08 Nicxe

Hi,

~~Try the entity variable within the ulm_custom_popup instead of the ulm_popup_weather_entity.~~ The weather popup already uses the entity variable of the card. There is no need to set the ulm_popup_weather_entity anymore.

For testing purposes try to use the popup on a generic card. I've taken a look in the code of the weather card and the card_esh_welcome card. Both aren't prepared to use the custom actions.

matrixx567 avatar Aug 10 '22 16:08 matrixx567

I tested on a generic card using the below code, and it worked as expected;

- type: 'custom:button-card'
  template: card_generic
  entity: weather.hackham
  variables:
    ulm_card_tap_action: "popup" 
    ulm_custom_popup:
      template: "popup_weather_forecast"

I tried both with and without the ulm_popup_weather_entity flag, it didn't make any difference (ie it still worked on the generic card and didn't on the weather card) so I will remove it.

tropics1999 avatar Aug 11 '22 07:08 tropics1999

Hi @tropics1999,

I've done some testing with the weather card. I've found a way to enable custom actions for this card. I will provide a pull request within the next days.

matrixx567 avatar Aug 11 '22 08:08 matrixx567

Thank you @matrixx567 - I'll be very keen to see it work 😄

tropics1999 avatar Aug 12 '22 06:08 tropics1999

My configuration to call the popup

  - type: "custom:button-card"
    template: card_weather
    entity: weather.home
    variables:
      ulm_card_weather_name: " "
      ulm_card_weather_primary_info:
        - wind_speed
        - precipitation_probability
      ulm_card_weather_backdrop:
        fade: true
      ulm_card_tap_action: adaptive
      ulm_custom_popup:
        template: "popup_weather_forecast"

matrixx567 avatar Aug 14 '22 09:08 matrixx567

My configuration to call the popup

I cant get that to work for me 😞

Nicxe avatar Aug 24 '22 14:08 Nicxe

@Nicxe

Have you included the files from the pull request?

matrixx567 avatar Aug 24 '22 15:08 matrixx567

Have you included the files from the pull request?

Must have got something wrong, not I got it to work. Thanks

Nicxe avatar Aug 26 '22 13:08 Nicxe

@matrixx567 thanks for your work on this! Is there a way to add the overlay to a chip card without applying the overlay to all chips?

For example, I am trying to add the weather pop up to the chip_weather_date card. The yaml for that points back to the chips.yaml template. I don't want to apply an overlay for all chips, but I still want the functionality while retaining some of the config info from the chips.yaml file. Is the easiest way for this to copy the chips.yaml config options needed into the chip_weather_date.yaml, then changing the template in that same file to ulm_actions_card_overlay?

SgtRootCanal avatar Aug 28 '22 00:08 SgtRootCanal

@SgtRootCanal

I havn't tested it, but try this configuration:

- type: custom:button-card
  template:
    - "chip_weather_date"
    - "ulm_actions_card_overlay"

For chips this configuration should also work

- type: custom:button-card
  template:
    - "chip_weather_date"
    - "ulm_custom_actions"
    - "ulm_actions_card"

Give both options a try and I would be happy for some feedback. If the second options works it should be the prefered way. I didn't have some time to test it.

matrixx567 avatar Aug 28 '22 18:08 matrixx567

I am a bit new to this. Should popups work on a non adaptive dashboard? I am realizing in my testing that NO popups at all are working for me and have been banging my head figuring out how to make them work.

SgtRootCanal avatar Sep 22 '22 15:09 SgtRootCanal