RE-UE4SS icon indicating copy to clipboard operation
RE-UE4SS copied to clipboard

Outdated custom game configs

Open UE4SS opened this issue 1 year ago • 6 comments

I noticed that the custom game configs haven't been updated alongside the default config, for example, the Jedi Survivor settings file.

Should we be updating these ? Maybe we've just completely forgotten about them ?

Should keep the signatures updated as well ? Because there's been no update to them for at least 5 months and it's possible games have updated and our custom files might not work.

If we should keep each config updated, how would we do that ? Adding new items, and removing old ones from the ini file is easy enough but testing to see if each game still works is obviously more cumbersome and obviously not every dev might have access to every game that we have custom configs for.

UE4SS avatar Feb 07 '24 02:02 UE4SS

Good point, these have indeed been forgetten about. Patternsleuth does still have support for the lua signature overrides but for the most part it's so good that it removes the need for many existing games to have them anymore. IIRC, in our database of roughly 1400 UE games, last report by Truman (3rd Jan) showed that there is >90% coverage for each AOB required by UE4SS.

image

Regarding testing if they are required anymore - I can ask longer/truman/narknon (who have access to the database) to check which games we have sigs for work with patternsleuth and which don't - avoids the need of finding people with the game installed to check manually.

Once we know which work, we can remove the sigs. For the ones that don't work, we'll need someone to check if those custom sigs still work (unless ps has a built in utility for that, but I can't remember). And obviously do whatever needs to be done from there.

Buckminsterfullerene02 avatar Feb 07 '24 12:02 Buckminsterfullerene02

Tracking comment

Checking if AOBs required

  • [x] Atomic Heart - need FNameToStringFString (probably inlined due to denuvo), StaticConstructObjectInternal (multiple addresses), EngineVersion
  • [x] Borderlands 3 - no custom AOBs required
  • [x] DeadIsland2 - no custom AOBs required
  • [x] Final Fantasy 7 Remake - need GUObjectArray and FNameToStringFString
  • [ ] Fuser - needs testing manually
  • [x] Ghost Wire Tokyo - need GUObjectArray, FTextFString and EngineVersion
  • [x] Kingdom Hearts 3 - need GUObjectArray and FNameToStringFString and FNameCtorWchar
  • [ ] Like a Dragon Ishin! - needs testing manually
  • [ ] Returnal - needs testing manually
  • [ ] SCP 5K - needs testing manually
  • [x] Satisfactory - see https://github.com/UE4SS-RE/RE-UE4SS/issues/348#issuecomment-1932551936
  • [x] Star Wars Jedi Fallen Order - no custom AOBs required
  • [x] Star Wars Jedi Survivor - no custom AOBs required
  • [x] The Outer Worlds - no custom AOBs required
  • [x] Walking Dead Saints & Sinners - need FNameToStringFString and StaticConstructObjectInternal
  • [x] cyubeVR - no custom AOBs required

Checking if existing AOBs still work for games that still need them

  • [ ] Atomic Heart - need FNameToStringFString (probably inlined due to denuvo), StaticConstructObjectInternal (multiple addresses), EngineVersion
  • [ ] Final Fantasy 7 Remake - need GUObjectArray and FNameToStringFString
  • [ ] Walking Dead Saints & Sinners - need FNameToStringFString and StaticConstructObjectInternal
  • [ ] Ghost Wire Tokyo - need GUObjectArray, FTextFString and EngineVersion
  • [ ] Kingdom Hearts 3 - need GUObjectArray and FNameToStringFString and FNameCtorWchar

Buckminsterfullerene02 avatar Feb 07 '24 14:02 Buckminsterfullerene02

Will need to also remember to update the custom game configs docs on whatever we change

Buckminsterfullerene02 avatar Feb 07 '24 16:02 Buckminsterfullerene02

Will need to also remember to update the custom game configs docs on whatever we change

It seems some of the links to the custom configs in the docs are broken right now. Specifically the ones that don't directly link to a file but instead link to a location in the repo and it looks like those links weren't updated after the configs were moved into the assets directory.

UE4SS avatar Feb 07 '24 17:02 UE4SS

Results for my manual test of Satisfactory Early Access, CL#273254 (latest as of now) with the current custom config for it:

[17:40:38] PS Scan attempt 15747
[17:40:38] [PS] Reading image
[17:40:38] [PS] Starting scan
[17:40:38] [PS] Scan finished in 567.1╡s
[17:40:38] [PS] Failed to find EngineVersion: expected at least one value
[17:40:38] [PS] You need to override the engine version in 'UE4SS-settings.ini'.
[17:40:38] [PS] Failed to find GUObjectArray: expected at least one value
[17:40:38] [PS] You can supply your own AOB in 'UE4SS_Signatures/GUObjectArray.lua'
[17:40:38] [PS] Failed to find GMalloc: expected at least one value
[17:40:38] [PS] You can supply your own AOB in 'UE4SS_Signatures/GMalloc.lua'
[17:40:38] [PS] Failed to find FName::ToString: expected at least one value
[17:40:38] [PS] You can supply your own AOB in 'UE4SS_Signatures/FName_ToString.lua'
[17:40:38] [PS] Failed to find StaticConstructObject_Internal: expected at least one value
[17:40:38] [PS] You can supply your own AOB in 'UE4SS_Signatures/StaticConstructObject.lua'
[17:40:38] [PS] Failed to find FText::FText(FString&&): expected at least one value
[17:40:38] [PS] You can supply your own AOB in 'UE4SS_Signatures/FText_Constructor.lua'
[17:40:38] [PS] Scan failed

[17:40:38] Fatal Error: PS scan timed out

Without the custom config, FName::FName is also not found. I've also noticed the game freezes and is no longer playable when PS gets done failing to scan. I don't know if that's intended or not but I thought I'd share just in case.

UE4SS avatar Feb 07 '24 17:02 UE4SS

I kind of forgot, of course the existing configs won't work for SF, the game has been updated to UE5.2 lol

Buckminsterfullerene02 avatar Feb 10 '24 11:02 Buckminsterfullerene02