urbansim icon indicating copy to clipboard operation
urbansim copied to clipboard

Returned 'removed_indexes' in transition function in class TabularGrowthRateTransition may be missing rows that are in 'data', but not in returned 'updated'.

Open stefancoe opened this issue 7 years ago • 3 comments

Please see this issue on our repo that describes the problem:

https://github.com/psrc/urbansim2/issues/123

stefancoe avatar Feb 13 '18 18:02 stefancoe

Just to follow up on the issue Stefan found. The problem happens when some rows of the data (say households) have characteristics that are not captured by the control totals table. These can be some outlier agents from the base year that we don't want to control for and should be removed. However, the link tables (say persons) do not remove rows belonging to these outlier agents.

hanase avatar Feb 13 '18 18:02 hanase

Yes- it turns out the missing households have an income of 49,999 or 74,999 so this is a problem with our control totals. But maybe a warning is warranted?

stefancoe avatar Feb 13 '18 19:02 stefancoe

Thanks for reporting this. Good to know that it was a control total issue. Agreed that a warning about some agents not being subject to the transition model would be a nice addition.

janowicz avatar Feb 21 '18 20:02 janowicz