synthpop icon indicating copy to clipboard operation
synthpop copied to clipboard

Memoryerror pd sum sum

Open cvanoli opened this issue 6 years ago • 2 comments

-Deleted pd.sum.sum which was giving memory error. Changed it to a for loop summing on every row

cvanoli avatar May 03 '18 12:05 cvanoli

Coverage Status

Coverage increased (+0.07%) to 82.873% when pulling d390e2fd57f676276f7b558675ac6bc95fd8189d on memoryerror_pd_sum_sum into c3588e40657e9e4df3773d656747634f0feb81e3 on master.

coveralls avatar May 03 '18 12:05 coveralls

@cvanoli Thanks. Per our existing discussions with @sablanchard, this low-memory change should be made an optional one (e.g. a high-level low_memory parameter that defaults to False), so that those with the requisite memory can avoid the for loop.

janowicz avatar May 08 '18 16:05 janowicz