ansible-conda icon indicating copy to clipboard operation
ansible-conda copied to clipboard

Contribute upstream to ansible-modules-extras

Open brianhelba opened this issue 9 years ago • 16 comments

This seems like it would be a worthy addition to upstream Ansible. Would you consider submitting this to https://github.com/ansible/ansible-modules-extras ?

If you're not interested in dealing with that process, I'd be happy to submit a PR to ansible-modules-extras myself (maintaining credit to you as Git author and copyright owner).

brianhelba avatar Jun 16 '15 19:06 brianhelba

I'll have to talk to my supervisors about this, but I'm 100% for it. Do you think the module needs to wrap up anymore conda functionality like environments?

jiffyclub avatar Jun 16 '15 21:06 jiffyclub

@jiffyclub Good point. I imagine that the module could be merged as-is, but it's going to much more difficult to maintain once it's merged into an upstream repo.

I'll ask some of the other Anaconda users in my organization to see if there are any feature requests that we could add now.

brianhelba avatar Jun 16 '15 22:06 brianhelba

@jiffyclub Also, when the PR to ansible-modules-extras is made, I'd prefer it be made in a way that preserves the full development history from here. It's not that difficult to graft this repo's history into the upstream one, so once we proceed, I can make the new branch in ansible-modules-extras, but you can issue the actual PR, if you'd like.

brianhelba avatar Jun 16 '15 22:06 brianhelba

I've just come upon a situation with a shared web server where I think it would be nice to be able to manage conda environments via Ansible. So it might be worthwhile keeping control of this for now.

jiffyclub avatar Jun 26 '15 22:06 jiffyclub

+1, I'll pass this along to the Anaconda Cluster dev team

koverholt avatar Jul 09 '15 19:07 koverholt

I just talked to @koverholt at SciPy today. He suggested that we also include support for fetching packages from custom channels.

Once the channels feature is added, and we ensure that environments are working properly, I think we'll be ready to submit this upstream.

brianhelba avatar Jul 09 '15 20:07 brianhelba

Also, apparently Conda already has support in Salt. We should probably look at that and see if there are any features we want to ~~shamelessly copy~~ implement for ourselves.

brianhelba avatar Jul 09 '15 20:07 brianhelba

@jiffyclub The current version does in fact allow managing environments by passing the --name argument in extra_args (at least with the fix in the PR #4 that I just submitted). But I agree it would be nice to have more "high-level" support for environments via a proper option in this module.

maxalbert avatar Aug 13 '15 08:08 maxalbert

+1 Has this been submitted upstream ?

lowks avatar May 25 '16 04:05 lowks

@lowks it has not.

jiffyclub avatar May 25 '16 04:05 jiffyclub

Oh. Any reason why not ?

lowks avatar May 25 '16 04:05 lowks

No particularly good reason, I think. If other people on this thread (particularly @brianhelba) are still interested and think it's ready we should see about it. But I've since changed jobs and I no longer actively work on this or have ultimate control.

jiffyclub avatar May 25 '16 04:05 jiffyclub

Right. @brianhelba ?? On Wed, 25 May 2016 at 12:28 PM, Matt Davis [email protected] wrote:

No particularly good reason, I think. If other people on this thread (particularly @brianhelba https://github.com/brianhelba) are still interested and think it's ready we should see about it. But I've since changed jobs and I no longer actively work on this or have ultimate control.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/UDST/ansible-conda/issues/1#issuecomment-221470256

lowks avatar May 25 '16 04:05 lowks

Sent for PR. https://github.com/ansible/ansible-modules-core/pull/3780

lowks avatar May 30 '16 02:05 lowks

Is there any work going on this PR?

RafalSkolasinski avatar Dec 07 '16 19:12 RafalSkolasinski

Hi guys, I've created a PR for a conda module upstream https://github.com/ansible/ansible/pull/40455

tmoschou avatar May 25 '18 00:05 tmoschou