npm-safe-install icon indicating copy to clipboard operation
npm-safe-install copied to clipboard

Rebuilding Links, Failed to execute command

Open trusktr opened this issue 5 years ago • 0 comments

Looks like nsi tries to npm link the linked packages that it unlinked, but npm link isn't always the way that the packages were originally linked. The linked packages may be linked in any fashion, for example using good ol' ln -s ../../path/to/some-package.

So because of that, we get an error like this:

Rebuilding Links
Failed to execute command: Error: Command failed: cd /home/trusktr/src/lume+lume/apps/website && npm link @lume/cli lume

but @lume/cli and lume are not linked to the global location like normal (i.e. npm link was not ran in those packages in order to link the to the global location).

I think what nsi should do instead is simply copy the link files, run the npm install, then finally move the link files back into their original locations (forcefully overwriting folders if needed).

trusktr avatar Oct 12 '20 04:10 trusktr