STIR icon indicating copy to clipboard operation
STIR copied to clipboard

Lmtoprojdata image duration dpends on time frame definitions

Open danieldeidda opened this issue 1 year ago • 3 comments

When creating the exam info LMtoProjdata get the examinfo from the LM but then set timeframe according to time frame definitions, so if this was not set in the parfile we will have a time duration of 0 even though the LM exam info had a value>0

https://github.com/UCL/STIR/blob/6417022e54a4814f25776bc8ca1df3acd4e865f6/src/listmode_buildblock/LmToProjData.cxx#L661-L665

or maybe I am missing something

danieldeidda avatar Sep 13 '24 16:09 danieldeidda

Higher up in the set_up() there is https://github.com/UCL/STIR/blob/6417022e54a4814f25776bc8ca1df3acd4e865f6/src/listmode_buildblock/LmToProjData.cxx#L426C7-L429 all_frames_exam_info_sptr is actually never used however. Presumably this should have been passed to the post_normalisation_sptr->set_up()

KrisThielemans avatar Sep 23 '24 14:09 KrisThielemans

We currently initialise frame_defs in set_up https://github.com/UCL/STIR/blob/6417022e54a4814f25776bc8ca1df3acd4e865f6/src/listmode_buildblock/LmToProjData.cxx#L437-L447 This should at least be modified to lm_data_ptr->get_exam_info_sptr()->get_time_frame_defs() if num_events_to_store is zero. (And write a warning otherwise).

KrisThielemans avatar Sep 23 '24 14:09 KrisThielemans

Duplicate of #657.

Related to problems with time frames is #161

KrisThielemans avatar Sep 23 '24 14:09 KrisThielemans