STIR icon indicating copy to clipboard operation
STIR copied to clipboard

MLEstimateComponentBasedNormalisation refactor

Open robbietuk opened this issue 5 months ago • 18 comments

Changes in this pull request

WIP

Refactor of ML_estimate_component_based_normalisation.

  • Created a class.
  • Simplified the system logic
  • Add the ability option to save the data or not

Remaining tasks

  • [x] Add methods to get_efficiencies(), get_norm_geo_data() and get_norm_block_data()
  • [x] Add methods to get and set the boolean values of do_geo, do_block, do_symmetry_per_block, do_KL, do_display, do_save_to_file
  • [x] Improve documentation defining the efficiencies, norm_geo_data, norm_block_data variables (even after all this work I am still slightly confused).
  • [x] Add unit tests

Testing performed

Added a new unit test for basic functionality.

Related issues

Fixes #1498

Checklist before requesting a review

  • [] I have performed a self-review of my code
  • [] I have added docstrings/doxygen in line with the guidance in the developer guide
  • [] I have implemented unit tests that cover any new or modified functionality (if applicable)
  • [] The code builds and runs on my machine
  • [] documentation/release_XXX.md has been updated with any functionality change (if applicable)

robbietuk avatar Aug 29 '24 20:08 robbietuk