STIR icon indicating copy to clipboard operation
STIR copied to clipboard

Published 20 hours ago • verified publisher icon UCL

TOF loop missing for Hessian computation

Open KrisThielemans opened this issue 1 year ago • 1 comments

PoissonLogLikelihoodWithLinearModelForMeanAndProjData::actual_add_multiplication_with_approximate_sub_Hessian_without_penalty and other Hessian function don't loop over TOF data

KrisThielemans avatar Jan 06 '24 09:01 KrisThielemans

Is this as simple as updating the relevant lines to use the ViewgramIndices (https://github.com/UCL/STIR/pull/1273), e.g. https://github.com/UCL/STIR/blob/75a9342157e59db6d43a968fa48f7d8c951853fb/src/recon_buildblock/PoissonLogLikelihoodWithLinearModelForMeanAndProjData.cxx#L949C49-L961

ghost avatar Jan 08 '24 19:01 ghost

@gschramm, this is going to create trouble...

KrisThielemans avatar May 15 '24 11:05 KrisThielemans

Actually, the list-mode Hessian should be fine.

KrisThielemans avatar May 15 '24 11:05 KrisThielemans

@KrisThielemans and I am using non-TOF mMR data from the examples ;)

gschramm avatar May 15 '24 11:05 gschramm

But good to keep that in mind and maybe warn people.

  • another reason to use torch.autograd.gradcheck to verify custom layers ...

gschramm avatar May 15 '24 11:05 gschramm

@gschramm I fixed this now.

KrisThielemans avatar May 16 '24 06:05 KrisThielemans