STIR icon indicating copy to clipboard operation
STIR copied to clipboard

Published 20 hours ago • verified publisher icon UCL

fixing geometrical factors

Open danieldeidda opened this issue 2 years ago • 5 comments

estimation of geometrical factors uses mirroring and symmetries and only saves half of the data. This does not work when the number of detectors per block is odd. The branch fixes this:

  • save the whole data
  • apply symmetries anyway to reduce noise

danieldeidda avatar Jan 12 '23 15:01 danieldeidda

the tests run OK and normalisation file created with the old version are the same

danieldeidda avatar Jan 12 '23 15:01 danieldeidda

Appveyor failure was my fault and is hopefully mixed on master in 63c2e9c6d505fe131d5766ff5f68188c9fb98bd5. Best to merge master in here therefore.

Probably best to do undo some white-space changes as well. I haven't reviewed the actual code yet.

KrisThielemans avatar Jan 12 '23 23:01 KrisThielemans

somehow not all the spaces I changed were modified as I was expecting

danieldeidda avatar Jan 13 '23 10:01 danieldeidda

not sure if I changed something wrong but this is not working anymore

danieldeidda avatar Apr 21 '23 13:04 danieldeidda

not sure if I changed something wrong but this is not working anymore

actually my branch was wrong in my computer this version does provide the same results:

image

danieldeidda avatar Apr 21 '23 16:04 danieldeidda