STIR icon indicating copy to clipboard operation
STIR copied to clipboard

Issue/1070 second iteration changes for parallelproj interface

Open markus-jehl opened this issue 2 years ago • 4 comments

Added a call to get the max_FOV_radius of the scanner, to fix the parallelproj interface for non-cylindrical scanners.

markus-jehl avatar Oct 04 '22 08:10 markus-jehl

Kris (https://github.com/UCL/STIR/pull/1074): "I suspect it isn't the image radius though. Could you check what parallelproj does if you give it a small radius? Instead I think we should check the return value of get_intersections_with_cylinder such that we don't ever use intersections with a cylinder where there aren't any,"

markus-jehl avatar Oct 06 '22 07:10 markus-jehl

I tested it, and parallelproj works as expected for smaller radii. I now also added handling of the return value of get_intersections_with_cylinder. The remaining things to be done are:

  1. Add parallelproj sections to existing tests and confirm they pass.
  2. Run Positrigo reconstruction pipeline to check there are no obvious bugs anymore.

markus-jehl avatar Oct 06 '22 07:10 markus-jehl

Do you intend to add the tests in this PR? Maybe best to finish this one and squash-merge it first.

KrisThielemans avatar Oct 06 '22 16:10 KrisThielemans

Initially, I was thinking of doing it as part of this PR - but I agree it would be nice to get this merged in sooner rather than later!

markus-jehl avatar Oct 07 '22 07:10 markus-jehl

IMPORTANT: currently, parallelproj truncates the resulting images to a cylinder with the inner ring radius of the scanner. This means any activity in the corners of a BlocksOnCylindrical scanner will be removed.

markus-jehl avatar Nov 15 '22 15:11 markus-jehl

AppVeyor time-outs

KrisThielemans avatar Nov 15 '22 18:11 KrisThielemans