INGInious
INGInious copied to clipboard
UCL-INGI
[Frontend] Allow RTL
Localization will increase the adoption of this system and allow more diverse people to use it.
Thank you.
Hello @yarons,
Thank u for your interest for INGInious project. Actually, Localization already exist and works with weblate : https://weblate.info.ucl.ac.be/engage/inginious/?utm_source=widget
If i misunderstood your issue, could you please explain it. Thank you.
Hey, yes, that answers my question yet Hebrew is unavailable, can you assist with that?
I'm also afraid that this is a pretty old Weblate version as the current version is 4.12.
I see from #811 that you successfully add Hebrew. So no need extra explanation :) I think you need to sign CLA btw.
Concerning version we will have a look.
Sure, there are small things that bother me, for example, in English the puctuation symbols are written without a space between them and the text, so I would write "For example:", in most strings there's a space before the colon: "For example :".
I can probably try and fix that in the source code but it should be the style for all new strings as well.
Where can I sign the CLA?
Feel certainly free to propose adaptation through a PR :)
You can sign CLA in the #811 PR :)
@Drumor Done :)
I'll see what I can do regarding the original strings, thank you.
That's fine but the English is still wrong, do you want me to open an additional issue about that?
Oh no, making a PR with English correction is more than enough :) Thank you.
Thx to @yarons awesome work, we have now Hebrew as available translation. It should be great to make RTL available on frontend to fix text alignments.
Based on our work, this should be done :
- Adding bootstraprtl (https://bootstrap.rtlcss.com/)
- Rebuild bootwatch theme to fit RTL
- Add feature to choose rtl or not based on selected language.
Question : Do we have to make modification like putting the menu on the right and so on? @yarons (or anyone else) if u have any advice about that, feel free to comment.
UX is a very complicated world, for example, moving the menu to the right is quite intuitive yet the fingers remain at the same length so depending on how you're holding your phone this change might not be very comfortable to everyone, yet in a desktop environment it's pretty natural to just flip everything so assuming it's only desktop we're looking at there shouldn't be any issue.