INGInious icon indicating copy to clipboard operation
INGInious copied to clipboard

Published 20 hours ago • verified publisher icon UCL-INGI

[filesystems/local] Local implementation of distribute() mismatch the specification

Open nrybowski opened this issue 2 years ago • 1 comments

The filesystem interface specifies that the type returned by distribute() must be {file, url, invalid}.

https://github.com/UCL-INGI/INGInious/blob/302f6beb712a848ea5465df052459869470e974a/inginious/common/filesystems/init.py#L137-L142

However, the local implementation returns 'local' as type.

https://github.com/UCL-INGI/INGInious/blob/302f6beb712a848ea5465df052459869470e974a/inginious/common/filesystems/local.py#L160

nrybowski avatar Mar 04 '22 10:03 nrybowski

After discussion, we will update the documentation to match the usages:

https://github.com/UCL-INGI/INGInious/blob/b60326b702022ffe41391e7b7b003b3b3bbb8080/inginious/frontend/pages/tasks.py#L418

https://github.com/UCL-INGI/INGInious/blob/b60326b702022ffe41391e7b7b003b3b3bbb8080/inginious/frontend/pages/course_admin/task_edit_file.py#L252

nrybowski avatar Mar 04 '22 13:03 nrybowski