Software icon indicating copy to clipboard operation
Software copied to clipboard

Use arrow as ball_is_off_ground.py validation test visual

Open nycrat opened this issue 2 months ago • 3 comments

Description

Create a 2D arrow under the ball directed to its velocity, shows where and the direction the ball is chipped in tests. Shows octagon (stop sign) when ball is not moving.

https://github.com/user-attachments/assets/9a5ac818-a12d-4e83-a550-a4ac70c5a50a

Testing Done

Ran crease_defender_tactics_test, which is the only test that uses the ball_is_off_ground validation

Resolved Issues

resolves #3244

Review Checklist

It is the reviewers responsibility to also make sure every item here has been covered

  • [x] Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
  • [x] Remove all commented out code
  • [x] Remove extra print statements: for example, those just used for testing
  • [x] Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue

nycrat avatar Oct 18 '25 20:10 nycrat

NOTE: a lot of changes come from the pre-commit auto-formatting, I'm not sure which one is the correct formatting. It was mentioned here https://github.com/UBC-Thunderbots/Software/pull/3499#issuecomment-3342461729

nycrat avatar Oct 18 '25 20:10 nycrat

nvm the bot updated the formatting its all good

nycrat avatar Nov 01 '25 20:11 nycrat

I'll attach some videos and screenshots of the visual test in this PR after I make some changes to resolve the comments you made about the code

nycrat avatar Nov 03 '25 20:11 nycrat