Software icon indicating copy to clipboard operation
Software copied to clipboard

[DOCS] Added Deoxygen Support

Open Mr-Anyone opened this issue 7 months ago • 8 comments

Description

Added Deoxygen support:

see this:

https://mr-anyone.github.io/Thunderbot_Software https://mr-anyone.github.io/Thunderbot_Software/classPlay.html https://mr-anyone.github.io/Thunderbot_Software/classTactic.html https://mr-anyone.github.io/Thunderbot_Software/classThreadedAi.html

see here: https://github.com/Mr-Anyone/Thunderbot_Software

Length Justification and Key Files to Review

Most of it is css file and config file. N/A

It is the reviewers responsibility to also make sure every item here has been covered

  • [X] Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
  • [X] Remove all commented out code
  • [X] Remove extra print statements: for example, those just used for testing
  • [X] Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue

Mr-Anyone avatar May 07 '25 23:05 Mr-Anyone

image

I think someone need to set this up because I don't have repo access.

Mr-Anyone avatar May 07 '25 23:05 Mr-Anyone

Small error here. See TOC image

Andrewyx avatar May 21 '25 20:05 Andrewyx

have you considered using rules_doxygen?

No, I haven't. I will give it an attempt.

Mr-Anyone avatar May 27 '25 03:05 Mr-Anyone

Small error here. See TOC image

looks useful, I think you may have messed up the table of contents rendering in a bunch of markdown files. otherwise, LGTM!

I assume you're referring to how the table of contents is displayed on GitHub (e.g., this page). As far as I can tell, the TOC generated by Doxygen itself is working as intended.

This is a bit painful to fix:

Doxygen uses the [TOC] tag to generate a table of contents (reference). However, GitHub doesn't recognize [TOC]—instead, we’ve been using this tool to create GitHub-compatible TOCs.

The problem is, including both [TOC] and the GitHub-generated TOC leads to formatting issues. On Doxygen pages, you get a random-looking list of pages; on GitHub, you’re left with the [TOC] tag rendered as plain text.

My thinking was to simplify this by moving all documentation to doxygen. I am not sure how to fix the rendering on both Github and doxygen at the same time.

Mr-Anyone avatar May 27 '25 03:05 Mr-Anyone

my sense is that right now, most people aren't looking at the locally rendered markdown files and just look online. So it's okay to ignore the markdown table of contents rendering in favour of doxygen (like you've done)

itsarune avatar May 27 '25 07:05 itsarune

Goodness gracious, rules_doxygen uses MODULE.bazel from bazel 8, if you do use it, can you branch off from the bazel 8 migration branch?

Andrewyx avatar Jun 01 '25 05:06 Andrewyx

Goodness gracious, rules_doxygen uses MODULE.bazel from bazel 8, if you do use it, can you branch off from the bazel 8 migration branch?

Sure. I will rebase from your branch or wait until you are done.

Mr-Anyone avatar Jun 01 '25 07:06 Mr-Anyone

@Mr-Anyone Should be safe for rebase now off the bzl branch

Andrewyx avatar Aug 18 '25 19:08 Andrewyx