Software icon indicating copy to clipboard operation
Software copied to clipboard

YAML Config Support Added

Open Mr-Anyone opened this issue 10 months ago • 5 comments

Description

Implemented a way to use yaml instead of redis

Testing Done

wrote some unit test. Going to field test on Saturday?

Resolved Issues

resolves #3315

Length Justification and Key Files to Review

N/A

Review Checklist

It is the reviewers responsibility to also make sure every item here has been covered

  • [X] Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
  • [X] Remove all commented out code
  • [X] Remove extra print statements: for example, those just used for testing
  • [X] Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue

Mr-Anyone avatar Feb 21 '25 02:02 Mr-Anyone

probably going to polish this after some field test.

Mr-Anyone avatar Feb 21 '25 02:02 Mr-Anyone

I have tested this on a robot:

this is a prove to work config file:

robot_id:             1
channel_id:           0
network_interface:    "wlan0"
kick_coeff:           0.275
kick_constant:        500
chip_pulse_width:     20000

Mr-Anyone avatar Feb 23 '25 01:02 Mr-Anyone

I will work on fixing that sometime this week

Mr-Anyone avatar Mar 23 '25 23:03 Mr-Anyone

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Apr 23 '25 03:04 github-actions[bot]

This PR was closed because it has been stalled for 5 days with no activity.

github-actions[bot] avatar Apr 28 '25 03:04 github-actions[bot]

On my end the following works:

# in terminal one
bazel run //software/embedded:thunderloop_main --//software/embedded:host_platform=LIMITED 
# in terminal two
./tbots.py run robot_diagnostics_cli 

The YAML config in both yaml_reader.hpp and the one pointer by ROBOT_PATH_TO_YAML_CONFIG

robot_id : 1
channel_id : 0 
network_interface : enp2s0
kick_coeff : 1.1
kick_constant : 1.2
chip_pulse_width : 1.3

Mr-Anyone avatar Jun 25 '25 14:06 Mr-Anyone

Also, it seems that @annieisawesome2 is taking over this one with TOML instead.

Mr-Anyone avatar Nov 09 '25 20:11 Mr-Anyone