Voltage colors
Description
Color of battery indicator in thunderscope diagnostics has been changed to a gradient from red to yellow to green. Red is at the minimum voltage and below, yellow at the center, and green at max voltage or above. Fixed the self.percentage variable, as the method was using int, causing the number to be 0 or 1 instead of a float.
Testing Done
Testing was done by connecting to a robot in the mezz, and changing out the batteries. Continued testing by plugging in different percentage values to cause color changes.
Resolved Issues
#3395
Length Justification and Key Files to Review
common_widgets.py
Review Checklist
- [ x] Function & Class comments: All function definitions (usually in the
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class. - [x] Remove all commented out code
- [x] Remove extra print statements: for example, those just used for testing
- [x ] Resolve all TODO's: All
TODO(or similar) statements should either be completed or associated with a github issue
You need to change the dependencies in the BUILD file to include util.py, so that your CL tests pass.
This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.
@GrayHoang can you pull master into this branch and you should be good to merge
It's not my pr lol
It's not my pr lol
Oh whoops. The email notification showed me your last comment. @Muxite