Software icon indicating copy to clipboard operation
Software copied to clipboard

Example play to FSM

Open someone2060 opened this issue 1 year ago • 6 comments

Please fill out the following before requesting review on this PR

Description

Converts the Example Play from a co-routine to an FSM.

The example play was moved to its own folder, with appropriate BUILD files modified. This was done to maintain consistency with other FSMs.

Testing Done

example_play_test.cpp successfully passed, and Example Play successfully ran on Thunderscope.

Resolved Issues

resolves #3298

Length Justification and Key Files to Review

  • example_play.cpp and corresponding .h file
  • example_play_fsm.cpp and corresponding .h file
  • example/BUILD

Review Checklist

It is the reviewers responsibility to also make sure every item here has been covered

  • [x] Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
  • [x] Remove all commented out code
  • [x] Remove extra print statements: for example, those just used for testing
  • [x] Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue

someone2060 avatar Oct 28 '24 06:10 someone2060

One of your tests is failing (software/geom/algorithms:end_in_obstacle_sample_test). Did you change this file? Try buildiing it in bazel and see what happens.

GrayHoang avatar Nov 11 '24 23:11 GrayHoang

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Dec 22 '24 03:12 github-actions[bot]

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Jan 23 '25 02:01 github-actions[bot]

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Mar 20 '25 03:03 github-actions[bot]

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Apr 22 '25 03:04 github-actions[bot]