Software icon indicating copy to clipboard operation
Software copied to clipboard

Rename all instances of stop tactic to halt tactic

Open someone2060 opened this issue 1 year ago • 1 comments

Please fill out the following before requesting review on this PR

Description

Renames all instances of stop tactic to halt tactic. ~~tactic.proto is now inconsistent with HaltTactic with this refactoring.~~ tactic.proto inconsistency has been fixed.

#3037 is a PR of the same issue, but was not merged.

Testing Done

halt_fsm_test, halt_tactic_test, and play_selection_fsm_test tests were run.

Resolved Issues

resolves #2630

Length Justification and Key Files to Review

Files in this folder have been renamed.

Review Checklist

It is the reviewers responsibility to also make sure every item here has been covered

  • [x] Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
  • [x] Remove all commented out code
  • [x] Remove extra print statements: for example, those just used for testing
  • [x] Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue

someone2060 avatar Oct 05 '24 01:10 someone2060

Looking good! just a couple nits

williamckha avatar Oct 05 '24 03:10 williamckha