Add referee display layer
Description
Add a referee info layer to display game state and command.
Testing steps:
- turn on "Referee Info" option in the "Layers" dropdown
- Expect to see info on the top right corner
Testing Done
- Thunderscope runs
- CI
Resolved Issues
resolves #3333
Demo
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
- [x] Function & Class comments: All function definitions (usually in the
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class. - [x] Remove all commented out code
- [x] Remove extra print statements: for example, those just used for testing
- [x] Resolve all TODO's: All
TODO(or similar) statements should either be completed or associated with a github issue
🔥
Would you also be able to incorporate #3289 into this PR? There's already another PR that never got merged which implements it.
Yes, sure. 👍
Just a little bit clarification here before I get started, is ball placement visulization supposed to be in the same layer with referee info?
In #3289, that's what being said, but in the associated PR, it seems to be added to a different layer.
Just a little bit clarification here before I get started, is ball placement visulization supposed to be in the same layer with referee info?
In #3289, that's what being said, but in the associated PR, it seems to be added to a different layer.
I would put the ball placement visualization in the Referee Info layer you created
Can you verify that this works with the recent preliminary arm PR #3316 (ie. pull upstream)? You may need to run ./setup_software,sh again from the env setup folder.
Can you verify that this works with the recent preliminary arm PR #3316 (ie. pull upstream)? You may need to run
./setup_software,shagain from the env setup folder.
@Andrewyx Reinstalled env and rebased, it worked on my side.
LGTM great work! Just some small nits.
This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.
@itsarune @williamckha Merged with master, manual tested and everything LGTM. Please review
Thanks William! 🍻