Software icon indicating copy to clipboard operation
Software copied to clipboard

Add referee display layer

Open Lmh-java opened this issue 1 year ago • 2 comments

Description

Add a referee info layer to display game state and command.

Testing steps:

  1. turn on "Referee Info" option in the "Layers" dropdown
  2. Expect to see info on the top right corner

Testing Done

  • Thunderscope runs
  • CI

Resolved Issues

resolves #3333

Demo

image image

Review Checklist

It is the reviewers responsibility to also make sure every item here has been covered

  • [x] Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
  • [x] Remove all commented out code
  • [x] Remove extra print statements: for example, those just used for testing
  • [x] Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue

Lmh-java avatar Oct 04 '24 04:10 Lmh-java

🔥

Would you also be able to incorporate #3289 into this PR? There's already another PR that never got merged which implements it.

Yes, sure. 👍

Lmh-java avatar Oct 05 '24 03:10 Lmh-java

Just a little bit clarification here before I get started, is ball placement visulization supposed to be in the same layer with referee info?

In #3289, that's what being said, but in the associated PR, it seems to be added to a different layer.

Lmh-java avatar Oct 05 '24 05:10 Lmh-java

Just a little bit clarification here before I get started, is ball placement visulization supposed to be in the same layer with referee info?

In #3289, that's what being said, but in the associated PR, it seems to be added to a different layer.

I would put the ball placement visualization in the Referee Info layer you created

williamckha avatar Oct 05 '24 15:10 williamckha

Can you verify that this works with the recent preliminary arm PR #3316 (ie. pull upstream)? You may need to run ./setup_software,sh again from the env setup folder.

Andrewyx avatar Oct 23 '24 08:10 Andrewyx

Can you verify that this works with the recent preliminary arm PR #3316 (ie. pull upstream)? You may need to run ./setup_software,sh again from the env setup folder.

@Andrewyx Reinstalled env and rebased, it worked on my side.

Lmh-java avatar Oct 24 '24 02:10 Lmh-java

LGTM great work! Just some small nits.

Andrewyx avatar Oct 25 '24 18:10 Andrewyx

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Jan 07 '25 03:01 github-actions[bot]

@itsarune @williamckha Merged with master, manual tested and everything LGTM. Please review

Lmh-java avatar Jan 20 '25 00:01 Lmh-java

Thanks William! 🍻

Lmh-java avatar Jan 25 '25 19:01 Lmh-java